Skip to content

CI failure: Test closure-compiler-npm #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brad4d opened this issue May 16, 2025 · 3 comments
Open

CI failure: Test closure-compiler-npm #4239

brad4d opened this issue May 16, 2025 · 3 comments
Assignees

Comments

@brad4d
Copy link
Contributor

brad4d commented May 16, 2025

The "Test closure-compiler-npm" CI step started failing yesterday.

The first failure is https://github.com/google/closure-compiler/actions/runs/15050974808/job/42306804232

Error message

compiler/.github/ci_support/test_closure-compiler-npm.sh compiler/bazel-bin/compiler_uberjar_deploy.jar
  shell: /usr/bin/bash -e {0}
  env:
    VERSION_NODEJS: 16.16.0
    UNSYMLINK_DIR: bazel-bin-unsymlink
    JAVA_HOME: /opt/hostedtoolcache/Java_Zulu_jdk/21.0.7-6/x6[4](https://github.com/google/closure-compiler/actions/runs/15050974808/job/42306804232#step:7:4)
    JAVA_HOME_21_X64: /opt/hostedtoolcache/Java_Zulu_jdk/21.0.7-6/x64
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version "20 || >=22". Got "16.16.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
yarn workspace v1.22.22
yarn run v1.22.22
error google-closure-compiler@202[5](https://github.com/google/closure-compiler/actions/runs/15050974808/job/42306804232#step:7:5)0226.0.0: The engine "node" is incompatible with this module. Expected version ">=18". Got "1[6](https://github.com/google/closure-compiler/actions/runs/15050974808/job/42306804232#step:7:6).16.0"
error Commands cannot run with an incompatible environment.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed.
Exit code: 1
Command: /opt/hostedtoolcache/node/16.16.0/x64/bin/node
Arguments: /usr/local/lib/node_modules/yarn/lib/cli.js run test --java-only --colors
Directory: /home/runner/work/closure-compiler/closure-compiler/packages/google-closure-compiler
Output:

info Visit https://yarnpkg.com/en/docs/cli/workspace for documentation about this command.
Error: Process completed with exit code 1.
@brad4d
Copy link
Contributor Author

brad4d commented May 16, 2025

Possibly this was triggered by changes @ChadKillingsworth made recently to https://github.com/google/closure-compiler-npm

@brad4d
Copy link
Contributor Author

brad4d commented May 16, 2025

#4240 is expected to fix this.

@brad4d brad4d self-assigned this May 16, 2025
@brad4d
Copy link
Contributor Author

brad4d commented May 16, 2025

Well, after #4240 it now fails differently.

https://github.com/google/closure-compiler/actions/runs/15076369919/job/42385686368

$ jasmine --reporter=jasmine-console-reporter test/*.js --java-only --colors
Unknown options: --java-only, --colors

I guess upgrading node also upgraded jasmine, and the new version doesn't support those 2 options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant