ci: check untracked files after build

Author: gcusnieux

.circleci/config.yml

@@ -171,17 +171,17 @@ workflows:
       - lint-test:
           requires:
             - install
+      - build:
+          requires:
+            - install
       - dangerjs:
           pre-steps:
             - secrethub/env-export:
                 secret-path: graviteeio/cicd/graviteebot/github_personal_access_token
                 var-name: DANGER_GITHUB_API_TOKEN
           context: gravitee-qa
           requires:
-            - install
-      - build:
-          requires:
-            - install
+            - build
       - prerelease:
           # Ignore this prerelease step on `master`
           filters:
@@ -194,11 +194,14 @@ workflows:
           context: gravitee-qa
           requires:
             - build
+            - lint-test
+            - dangerjs
       - trigger-chromatic:
           type: approval
           requires:
             - build
             - lint-test
+            - dangerjs
           # Ignore this manual step and trigger chromatic automatically on `master`
           filters:
             branches:

dangerfile.ts

@@ -1,27 +1,29 @@
-import { danger, markdown } from 'danger';
+import { danger, markdown, fail, schedule } from 'danger';
+import simpleGit, {SimpleGit} from 'simple-git';
+const git: SimpleGit = simpleGit();
 
 const modifiedDefinitionJson = danger.git.fileMatch('src/theme/definition.json');
 
 if (modifiedDefinitionJson.edited) {
   markdown(`
-Hey dear reviewer, I'm the Gravitee.io bot :robot:
+Hey dude, I'm the Gravitee.io bot :robot:
 
 I just want to tell you that \`definition.json\` has been updated in this PR. As this file is used to theme clients' portals you should carefully review it to avoid any regression!
 
 Also, after merging this PR, you should update the \`definition.json\` of [APIM Rest API](https://github.com/gravitee-io/gravitee-management-rest-api).
 `);
 }
 
-const packageJson = danger.git.fileMatch('package.json');
+schedule(async () => {
+  const result = await git.status();
+  if(result.modified.length > 0) {
+    fail(`
+Hey dude, I'm the Gravitee.io bot :robot:
 
-if (packageJson.edited) {
-  markdown(`
-Hey dear reviewer, I'm the Gravitee.io bot :robot:
-
-I just want to tell you that \`package.json\` has been updated in this PR. 
-
-Some components are based on third party libraries, for integration into a web component, we extract the css from its libraries as assets.
+There is some untracked files after \`npm run build\` command.
 
-WARNING: When \`codemirror\`, \`highlight.js\` or \`github-markdown-css\` are updated, we must run \`npm run build\` task to update the css.
+Could you run build command locally and fix-it ?
 `);
-}
+
+  }
+})

package-lock.json

@@ -116,6 +116,7 @@
     "pascal-case": "3.1.2",
     "prettier": "2.4.1",
     "semantic-release": "18.0.0",
+    "simple-git": "^2.47.0",
     "sort-package-json": "1.52.0",
     "svgo": "2.8.0",
     "svgstore": "3.0.1",