Skip to content

Commit 09a8462

Browse files
guillermoscriptguillermoscript
authored
Merge pull request #75 from guillermoscript/qa-review
Minor fixes
2 parents 29a4c38 + bdcb04a commit 09a8462

File tree

20 files changed

+264
-223
lines changed

20 files changed

+264
-223
lines changed

‎.eslintrc.json

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,22 @@
3030
// ,"prettier",
3131
],
3232
"rules": {
33-
"indent": ["off", 4],
34-
"@typescript-eslint/indent" : ["error", 4],
33+
"@typescript-eslint/space-before-function-paren": "off",
34+
"indent": [
35+
"off",
36+
4
37+
],
38+
"@typescript-eslint/indent": [
39+
"error",
40+
4
41+
],
3542
"prettier/prettier": "off",
3643
"@next/next/no-img-element": "off",
3744
"@typescript-eslint/no-unused-vars": "off",
3845
"@typescript-eslint/no-redeclare": "off",
3946
"@typescript-eslint/ban-ts-comment": "off",
4047
"react/jsx-indent-props": [
41-
"off",
48+
"off",
4249
4
4350
],
4451
"no-tabs": "off",
@@ -96,8 +103,9 @@
96103
}
97104
],
98105
"react-hooks/exhaustive-deps": "off",
99-
"unused-imports/no-unused-imports": "error"
100-
106+
"unused-imports/no-unused-imports": "error",
107+
"@typescript-eslint/comma-dangle": "off",
108+
"@typescript-eslint/member-delimiter-style": "off"
101109
},
102110
"overrides": [
103111
{

‎.prettierrc.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"trailingComma": "es5",
3+
"tabWidth": 4,
4+
"semi": false,
5+
"singleQuote": true,
6+
"useTabs": false
7+
}

‎app/dashboard/admin/courses/[courseId]/lessonsCols.tsx

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
DropdownMenu,
1111
DropdownMenuContent,
1212
DropdownMenuLabel,
13-
DropdownMenuTrigger
13+
DropdownMenuTrigger,
1414
} from '@/components/ui/dropdown-menu'
1515
import { DataTableColumnHeader } from '@/components/ui/Table/DataTableColumnHeader'
1616

@@ -29,30 +29,30 @@ export const lessonsCols: Array<ColumnDef<Lessons>> = [
2929
accessorKey: 'id',
3030
header: ({ column }) => (
3131
<DataTableColumnHeader column={column} title="ID" />
32-
)
32+
),
3333
},
3434
{
3535
accessorKey: 'title',
36-
header: 'Title'
36+
header: 'Title',
3737
},
3838
{
3939
accessorKey: 'description',
40-
header: 'Description'
40+
header: 'Description',
4141
},
4242
{
4343
accessorKey: 'sequence',
4444
header: ({ column }) => (
4545
<DataTableColumnHeader column={column} title="Sequence" />
46-
)
46+
),
4747
},
4848
{
4949
accessorKey: 'date',
50-
header: 'Date'
50+
header: 'Date',
5151
},
5252
{
5353
accessorKey: 'actions',
5454
header: ({ column }) => (
55-
<DataTableColumnHeader column={column} title="Acciones" />
55+
<DataTableColumnHeader column={column} title="Actions" />
5656
),
5757
cell: ({ row }) => {
5858
const rowData = row.original
@@ -67,18 +67,22 @@ export const lessonsCols: Array<ColumnDef<Lessons>> = [
6767
</DropdownMenuTrigger>
6868
<DropdownMenuContent align="end">
6969
<DropdownMenuLabel>
70-
<Link
71-
href={`/dashboard/teacher/courses/${rowData.courseId}/lessons/${rowData.id}`}
72-
>
73-
Ver detalles
74-
</Link>
70+
<Button asChild variant="ghost" className="w-full">
71+
<Link
72+
href={`/dashboard/teacher/courses/${rowData.courseId}/lessons/${rowData.id}`}
73+
>
74+
View Details
75+
</Link>
76+
</Button>
7577
</DropdownMenuLabel>
7678
<DropdownMenuLabel>
77-
<DeleteLessonAlert lessonId={rowData.id.toString()} />
79+
<DeleteLessonAlert
80+
lessonId={rowData.id.toString()}
81+
/>
7882
</DropdownMenuLabel>
7983
</DropdownMenuContent>
8084
</DropdownMenu>
8185
)
82-
}
83-
}
86+
},
87+
},
8488
]

‎app/dashboard/admin/courses/[courseId]/tests/[testId]/testSubmissionsCols.tsx

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
DropdownMenu,
99
DropdownMenuContent,
1010
DropdownMenuLabel,
11-
DropdownMenuTrigger
11+
DropdownMenuTrigger,
1212
} from '@/components/ui/dropdown-menu'
1313
import { DataTableColumnHeader } from '@/components/ui/Table/DataTableColumnHeader'
1414

@@ -25,16 +25,16 @@ export const testSubmissionsCols: Array<ColumnDef<TestSubmissions>> = [
2525
accessorKey: 'id',
2626
header: ({ column }) => (
2727
<DataTableColumnHeader column={column} title="ID" />
28-
)
28+
),
2929
},
3030
{
3131
accessorKey: 'date',
32-
header: 'Date'
32+
header: 'Date',
3333
},
3434
{
3535
accessorKey: 'actions',
3636
header: ({ column }) => (
37-
<DataTableColumnHeader column={column} title="Acciones" />
37+
<DataTableColumnHeader column={column} title="Actions" />
3838
),
3939
cell: ({ row }) => {
4040
const rowData = row.original
@@ -49,15 +49,17 @@ export const testSubmissionsCols: Array<ColumnDef<TestSubmissions>> = [
4949
</DropdownMenuTrigger>
5050
<DropdownMenuContent align="end">
5151
<DropdownMenuLabel>
52-
<Link
53-
href={`/dashboard/teacher/courses/${rowData.courseId}/tests/${rowData.testId}/review/${rowData.id}`}
54-
>
55-
Ver detalles
56-
</Link>
52+
<Button asChild variant="ghost" className="w-full">
53+
<Link
54+
href={`/dashboard/teacher/courses/${rowData.courseId}/tests/${rowData.testId}/review/${rowData.id}`}
55+
>
56+
View submission
57+
</Link>
58+
</Button>
5759
</DropdownMenuLabel>
5860
</DropdownMenuContent>
5961
</DropdownMenu>
6062
)
61-
}
62-
}
63+
},
64+
},
6365
]

‎app/dashboard/admin/courses/[courseId]/testsCols.tsx

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
DropdownMenu,
1111
DropdownMenuContent,
1212
DropdownMenuLabel,
13-
DropdownMenuTrigger
13+
DropdownMenuTrigger,
1414
} from '@/components/ui/dropdown-menu'
1515
import { DataTableColumnHeader } from '@/components/ui/Table/DataTableColumnHeader'
1616

@@ -29,30 +29,30 @@ export const testsCols: Array<ColumnDef<Tests>> = [
2929
accessorKey: 'id',
3030
header: ({ column }) => (
3131
<DataTableColumnHeader column={column} title="ID" />
32-
)
32+
),
3333
},
3434
{
3535
accessorKey: 'title',
36-
header: 'Title'
36+
header: 'Title',
3737
},
3838
{
3939
accessorKey: 'description',
40-
header: 'Description'
40+
header: 'Description',
4141
},
4242
{
4343
accessorKey: 'sequence',
4444
header: ({ column }) => (
4545
<DataTableColumnHeader column={column} title="Sequence" />
46-
)
46+
),
4747
},
4848
{
4949
accessorKey: 'date',
50-
header: 'Date'
50+
header: 'Date',
5151
},
5252
{
5353
accessorKey: 'actions',
5454
header: ({ column }) => (
55-
<DataTableColumnHeader column={column} title="Acciones" />
55+
<DataTableColumnHeader column={column} title="Actions" />
5656
),
5757
cell: ({ row }) => {
5858
const rowData = row.original
@@ -67,18 +67,20 @@ export const testsCols: Array<ColumnDef<Tests>> = [
6767
</DropdownMenuTrigger>
6868
<DropdownMenuContent align="end">
6969
<DropdownMenuLabel>
70-
<Link
71-
href={`/dashboard/teacher/courses/${rowData.courseId}/tests/${rowData.id}`}
72-
>
73-
Ver detalles
74-
</Link>
70+
<Button asChild variant="ghost" className="w-full">
71+
<Link
72+
href={`/dashboard/teacher/courses/${rowData.courseId}/tests/${rowData.id}`}
73+
>
74+
View test
75+
</Link>
76+
</Button>
7577
</DropdownMenuLabel>
7678
<DropdownMenuLabel>
7779
<DeleteTestAlert testId={rowData.id.toString()} />
7880
</DropdownMenuLabel>
7981
</DropdownMenuContent>
8082
</DropdownMenu>
8183
)
82-
}
83-
}
84+
},
85+
},
8486
]

‎app/dashboard/admin/courses/courseCols.tsx

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
DialogContent,
99
DialogHeader,
1010
DialogTitle,
11-
DialogTrigger
11+
DialogTrigger,
1212
} from '@/components/ui/dialog'
1313
import { DataTableColumnHeader } from '@/components/ui/Table/DataTableColumnHeader'
1414

@@ -26,28 +26,28 @@ export const courseCols: Array<ColumnDef<Course>> = [
2626
accessorKey: 'id',
2727
header: ({ column }) => (
2828
<DataTableColumnHeader column={column} title="ID" />
29-
)
29+
),
3030
},
3131
{
3232
accessorKey: 'title',
33-
header: 'Title'
33+
header: 'Title',
3434
},
3535
{
3636
accessorKey: 'description',
37-
header: 'Description'
37+
header: 'Description',
3838
},
3939
{
4040
accessorKey: 'status',
41-
header: 'Status'
41+
header: 'Status',
4242
},
4343
{
4444
accessorKey: 'date',
45-
header: 'Date'
45+
header: 'Date',
4646
},
4747
{
4848
accessorKey: 'actions',
4949
header: ({ column }) => (
50-
<DataTableColumnHeader column={column} title="Acciones" />
50+
<DataTableColumnHeader column={column} title="Actions" />
5151
),
5252
cell: ({ row }) => {
5353
const rowData = row.original
@@ -60,13 +60,15 @@ export const courseCols: Array<ColumnDef<Course>> = [
6060
</DialogTrigger>
6161
<DialogContent>
6262
<DialogHeader>
63-
<DialogTitle>Link product to course</DialogTitle>
63+
<DialogTitle>
64+
Link product to course
65+
</DialogTitle>
6466
</DialogHeader>
6567
<ConvertCourseToProduct rowData={rowData} />
6668
</DialogContent>
6769
</Dialog>
6870
</>
6971
)
70-
}
71-
}
72+
},
73+
},
7274
]

‎app/dashboard/teacher/courses/[courseId]/lessons/[lessonId]/edit/page.tsx

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,18 @@ import {
44
BreadcrumbItem,
55
BreadcrumbLink,
66
BreadcrumbList,
7-
BreadcrumbSeparator
7+
BreadcrumbSeparator,
88
} from '@/components/ui/breadcrumb'
99
import { createClient } from '@/utils/supabase/server'
1010

1111
// Force the page to be dynamic and allow streaming responses up to 30 seconds
1212
export const dynamic = 'force-dynamic'
1313
export const maxDuration = 30
1414

15-
export default async function EditLessonPage ({
16-
params
15+
export default async function EditLessonPage({
16+
params,
1717
}: {
18-
params: { courseId: string, lessonId: string }
18+
params: { courseId: string; lessonId: string }
1919
}) {
2020
const supabase = createClient()
2121
const lesson = await supabase
@@ -35,19 +35,19 @@ export default async function EditLessonPage ({
3535
<BreadcrumbList>
3636
<BreadcrumbItem>
3737
<BreadcrumbLink href="/dashboard">
38-
Dashboard
38+
Dashboard
3939
</BreadcrumbLink>
4040
</BreadcrumbItem>
4141
<BreadcrumbSeparator />
4242
<BreadcrumbItem>
4343
<BreadcrumbLink href="/dashboard/teacher">
44-
Teacher
44+
Teacher
4545
</BreadcrumbLink>
4646
</BreadcrumbItem>
4747
<BreadcrumbSeparator />
4848
<BreadcrumbItem>
4949
<BreadcrumbLink href="/dashboard/teacher/courses">
50-
Courses
50+
Courses
5151
</BreadcrumbLink>
5252
</BreadcrumbItem>
5353
<BreadcrumbSeparator />
@@ -83,7 +83,8 @@ export default async function EditLessonPage ({
8383
status: lesson?.data?.status,
8484
content: lesson?.data?.content,
8585
description: lesson?.data?.description,
86-
systemPrompt: lesson?.data.lessons_ai_tasks[0]?.system_prompt
86+
systemPrompt:
87+
lesson?.data.lessons_ai_tasks[0]?.system_prompt,
8788
}}
8889
/>
8990
</>

0 commit comments

Comments
 (0)