feat: add data source tests

Author: stefanfreitag

.changelog/43282.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+data-source/aws_route53_resolver_rule: Add `delegation_record` argument
+```
+
+```release-note:enhancement
+resource/aws_route53_resolver_rule: Add `delegation_record` argument
+```

internal/service/route53resolver/rule_data_source_test.go

@@ -180,6 +180,49 @@ func TestAccRoute53ResolverRuleDataSource_sharedWithMe(t *testing.T) {
 	})
 }
 
+func TestAccRoute53ResolverRuleDataSource_delegationRecord(t *testing.T) {
+	ctx := acctest.Context(t)
+	delegationRecord := acctest.RandomDomainName()
+	rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
+	resourceName := "aws_route53_resolver_rule.test"
+	ds1ResourceName := "data.aws_route53_resolver_rule.by_resolver_rule_id"
+	ds2ResourceName := "data.aws_route53_resolver_rule.by_name_and_rule_type"
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.PreCheck(ctx, t); testAccPreCheck(ctx, t) },
+		ErrorCheck:               acctest.ErrorCheck(t, names.Route53ResolverServiceID),
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccRuleDataSourceConfig_delegatationRecord(rName, delegationRecord),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttrPair(ds1ResourceName, names.AttrID, resourceName, names.AttrID),
+					resource.TestCheckResourceAttrPair(ds1ResourceName, names.AttrARN, resourceName, names.AttrARN),
+					resource.TestCheckResourceAttrPair(ds1ResourceName, "delegation_record", resourceName, "delegation_record"),
+					resource.TestCheckResourceAttrPair(ds1ResourceName, names.AttrName, resourceName, names.AttrName),
+					resource.TestCheckResourceAttrPair(ds1ResourceName, names.AttrOwnerID, resourceName, names.AttrOwnerID),
+					resource.TestCheckResourceAttrPair(ds1ResourceName, "resolver_endpoint_id", resourceName, "resolver_endpoint_id"),
+					resource.TestCheckResourceAttrPair(ds1ResourceName, "resolver_rule_id", resourceName, names.AttrID),
+					resource.TestCheckResourceAttrPair(ds1ResourceName, "rule_type", resourceName, "rule_type"),
+					resource.TestCheckResourceAttrPair(ds1ResourceName, "share_status", resourceName, "share_status"),
+					resource.TestCheckResourceAttrPair(ds1ResourceName, acctest.CtTagsPercent, resourceName, acctest.CtTagsPercent),
+
+					resource.TestCheckResourceAttrPair(ds2ResourceName, names.AttrID, resourceName, names.AttrID),
+					resource.TestCheckResourceAttrPair(ds2ResourceName, names.AttrARN, resourceName, names.AttrARN),
+					resource.TestCheckResourceAttrPair(ds2ResourceName, "delegation_record", resourceName, "delegation_record"),
+					resource.TestCheckResourceAttrPair(ds2ResourceName, names.AttrName, resourceName, names.AttrName),
+					resource.TestCheckResourceAttrPair(ds2ResourceName, names.AttrOwnerID, resourceName, names.AttrOwnerID),
+					resource.TestCheckResourceAttrPair(ds2ResourceName, "resolver_endpoint_id", resourceName, "resolver_endpoint_id"),
+					resource.TestCheckResourceAttrPair(ds2ResourceName, "resolver_rule_id", resourceName, names.AttrID),
+					resource.TestCheckResourceAttrPair(ds2ResourceName, "rule_type", resourceName, "rule_type"),
+					resource.TestCheckResourceAttrPair(ds2ResourceName, "share_status", resourceName, "share_status"),
+					resource.TestCheckResourceAttrPair(ds2ResourceName, acctest.CtTagsPercent, resourceName, acctest.CtTagsPercent),
+				),
+			},
+		},
+	})
+}
+
 func testAccRuleDataSourceConfig_basic(rName, domainName string) string {
 	return fmt.Sprintf(`
 resource "aws_route53_resolver_rule" "test" {
@@ -203,6 +246,26 @@ data "aws_route53_resolver_rule" "by_name_and_rule_type" {
 `, rName, domainName)
 }
 
+func testAccRuleDataSourceConfig_delegatationRecord(rName, delegationRecord string) string {
+	return acctest.ConfigCompose(testAccRuleConfig_resolverEndpointBase(rName), fmt.Sprintf(`
+resource "aws_route53_resolver_rule" "test" {
+  delegation_record = %[2]q
+  rule_type   = "DELEGATE"
+  name        = %[1]q
+  resolver_endpoint_id = aws_route53_resolver_endpoint.test[1].id
+}
+
+data "aws_route53_resolver_rule" "by_resolver_rule_id" {
+  resolver_rule_id = aws_route53_resolver_rule.test.id
+}
+
+data "aws_route53_resolver_rule" "by_name_and_rule_type" {
+  name      = aws_route53_resolver_rule.test.name
+  rule_type = aws_route53_resolver_rule.test.rule_type
+}
+`, rName, delegationRecord))
+}
+
 func testAccRuleDataSourceConfig_resolverEndpointIDTags(rName, domainName string) string {
 	return acctest.ConfigCompose(testAccRuleConfig_resolverEndpointBase(rName), fmt.Sprintf(`
 resource "aws_route53_resolver_rule" "test" {

internal/service/route53resolver/rule_test.go

@@ -227,7 +227,7 @@ func TestAccRoute53ResolverRule_updateName(t *testing.T) {
 	})
 }
 
-func TestAccRoute53ResolverRule_delegate(t *testing.T) {
+func TestAccRoute53ResolverRule_delegationRecord(t *testing.T) {
 	ctx := acctest.Context(t)
 	var rule1 awstypes.ResolverRule
 	resourceName := "aws_route53_resolver_rule.test"
@@ -243,7 +243,7 @@ func TestAccRoute53ResolverRule_delegate(t *testing.T) {
 		CheckDestroy:             testAccCheckRuleDestroy(ctx),
 		Steps: []resource.TestStep{
 			{
-				Config: testAccRuleConfig_delegate(rName, delegationRecord, 0),
+				Config: testAccRuleConfig_delegationRecord(rName, delegationRecord, 0),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckRuleExists(ctx, resourceName, &rule1),
 					resource.TestCheckResourceAttr(resourceName, "delegation_record", delegationRecord),
@@ -258,7 +258,7 @@ func TestAccRoute53ResolverRule_delegate(t *testing.T) {
 				ImportStateVerify: true,
 			},
 			{
-				Config: testAccRuleConfig_delegate(rName, delegationRecord, 1),
+				Config: testAccRuleConfig_delegationRecord(rName, delegationRecord, 1),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckRuleExists(ctx, resourceName, &rule1),
 					resource.TestCheckResourceAttr(resourceName, "delegation_record", delegationRecord),
@@ -714,7 +714,7 @@ resource "aws_route53_resolver_rule" "test" {
 `, rName, domainName)
 }
 
-func testAccRuleConfig_delegate(rName, delegationRecord string, resolverEndpointId int) string {
+func testAccRuleConfig_delegationRecord(rName, delegationRecord string, resolverEndpointId int) string {
 	return acctest.ConfigCompose(testAccRuleConfig_resolverEndpointBase(rName), fmt.Sprintf(`
 resource "aws_route53_resolver_rule" "test" {
   delegation_record = %[2]q