Skip to content

Commit e5b16a0

Browse files
Stefan-Tribeikov
authored andcommitted
HHH-19558: Improved Test
1 parent 3326eed commit e5b16a0

File tree

1 file changed

+17
-7
lines changed

1 file changed

+17
-7
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/sql/SQLQueryParserUnitTests.java

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
import org.hibernate.testing.orm.junit.SessionFactory;
1414
import org.hibernate.testing.orm.junit.SessionFactoryScope;
1515
import org.junit.jupiter.api.Test;
16+
import org.junit.jupiter.params.ParameterizedTest;
17+
import org.junit.jupiter.params.provider.ValueSource;
1618

1719
import static org.assertj.core.api.Assertions.assertThat;
1820

@@ -24,25 +26,33 @@
2426
@SuppressWarnings("JUnitMalformedDeclaration")
2527
public class SQLQueryParserUnitTests {
2628

27-
@Test
29+
@ParameterizedTest
2830
@DomainModel
2931
@SessionFactory
3032
@RequiresDialect(H2Dialect.class)
31-
void testJDBCEscapeSyntaxParsing(SessionFactoryScope scope) {
33+
@ValueSource(strings = {
34+
"{d '2025-06-18'}",
35+
"{t '14:00'}",
36+
"{t '14:00:00'}",
37+
"{ts '2025-06-18T14:00'}",
38+
"{ts '2025-06-18T14:00:00'}",
39+
"{ts '2025-06-18T14:00:00.123'}",
40+
"{ts '2025-06-18T14:00:00+01:00'}"})
41+
void testJDBCEscapeSyntaxParsing(String variant, SessionFactoryScope scope) {
3242
final SessionFactoryImplementor sessionFactory = scope.getSessionFactory();
33-
final String sqlQuery = "select id, name from {h-domain}the_table where date = {d '2025-06-18'}";
43+
final String sqlQuery = "select id, name from {h-domain}the_table where date = " + variant;
3444

3545
final String full = processSqlString( sqlQuery, "my_catalog", "my_schema", sessionFactory );
36-
assertThat( full ).contains( "{d '2025-06-18'}" );
46+
assertThat( full ).contains( variant );
3747

3848
final String catalogOnly = processSqlString( sqlQuery, "my_catalog", null, sessionFactory );
39-
assertThat( catalogOnly ).contains( "{d '2025-06-18'}" );
49+
assertThat( catalogOnly ).contains( variant );
4050

4151
final String schemaOnly = processSqlString( sqlQuery, null, "my_schema", sessionFactory );
42-
assertThat( schemaOnly ).contains( "{d '2025-06-18'}" );
52+
assertThat( schemaOnly ).contains( variant );
4353

4454
final String none = processSqlString( sqlQuery, null, null, sessionFactory );
45-
assertThat( none ).contains( "{d '2025-06-18'}" );
55+
assertThat( none ).contains( variant );
4656
}
4757

4858
private static String processSqlString(

0 commit comments

Comments
 (0)