Merge pull request #29 from galbaneim-orca/EE-629-error-when-parsing-file-names-with-parentheses-in-codeowners-open-source

EE-629 fix fork parsing ( ) bug

Author: hmarr

parse.go

@@ -245,7 +245,7 @@ func isAlphanumeric(ch rune) bool {
 // isPatternChar matches characters that are allowed in patterns
 func isPatternChar(ch rune) bool {
 	switch ch {
-	case '*', '?', '.', '/', '@', '_', '+', '-', '\\':
+	case '*', '?', '.', '/', '@', '_', '+', '-', '\\', '(', ')':
 		return true
 	}
 	return isAlphanumeric(ch)

parse_test.go

@@ -31,6 +31,38 @@ func TestParseRule(t *testing.T) {
 				Owners:  []Owner{{Value: "org/team", Type: "team"}},
 			},
 		},
+		{
+			name: "team owners file with parentheses",
+			rule: "file(1).txt @org/team",
+			expected: Rule{
+				pattern: mustBuildPattern(t, "file(1).txt"),
+				Owners:  []Owner{{Value: "org/team", Type: "team"}},
+			},
+		},
+		{
+			name: "team owners file with one parentheses on the left",
+			rule: "file(1.txt @user",
+			expected: Rule{
+				pattern: mustBuildPattern(t, "file(1.txt"),
+				Owners:  []Owner{{Value: "user", Type: "username"}},
+			},
+		},
+		{
+			name: "team owners file with one parentheses on the right",
+			rule: "file1).txt [email protected]",
+			expected: Rule{
+				pattern: mustBuildPattern(t, "file1).txt"),
+				Owners:  []Owner{{Value: "[email protected]", Type: "email"}},
+			},
+		},
+		{
+			name: "team owners file with parentheses in the folder name",
+			rule: "(folder)/file.txt @org/team",
+			expected: Rule{
+				pattern: mustBuildPattern(t, "(folder)/file.txt"),
+				Owners:  []Owner{{Value: "org/team", Type: "team"}},
+			},
+		},
 		{
 			name: "email owners",
 			rule: "file.txt [email protected]",