Merge pull request #106 from tobyzerner/name-instance-cache

tonysm · web-flow · commit 8a2737384453 · 2023-04-06T22:35:13.000-03:00
Reuse `Name` instances to improve performance
diff --git a/src/Models/Naming/Name.php b/src/Models/Naming/Name.php
@@ -50,9 +50,13 @@ class Name
      */
     public string $element;
 
+    private static array $nameInstanceCache = [];
+
     public static function forModel(object $model)
     {
-        return static::build(get_class($model));
+        $class = $model::class;
+
+        return static::$nameInstanceCache[$class] ??= static::build($class);
     }
 
     public static function build(string $className)

Original file line number	Diff line number	Diff line change
`@@ -50,9 +50,13 @@ class Name`
`50`	`50`	`*/`
`51`	`51`	`public string $element;`
`52`	`52`
	`53`	`+ private static array $nameInstanceCache = [];`
	`54`	`+`
`53`	`55`	`public static function forModel(object $model)`
`54`	`56`	`{`
`55`		`- return static::build(get_class($model));`
	`57`	`+ $class = $model::class;`
	`58`	`+`
	`59`	`+ return static::$nameInstanceCache[$class] ??= static::build($class);`
`56`	`60`	`}`
`57`	`61`
`58`	`62`	`public static function build(string $className)`