Skip to content

[idefics3] fix for vLLM #39470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zucchini-nlp
Copy link
Member

@zucchini-nlp zucchini-nlp commented Jul 17, 2025

What does this PR do?

As per title, the recent integration tests are failing because Idefics had an edge case. We can't assume num_cols == num_rows because idefics can output non-square images

See vllm-project/vllm#20543 (comment) for more

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: idefics3, smolvlm

@zucchini-nlp zucchini-nlp requested a review from qubvel July 18, 2025 08:23
Copy link
Member

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, do we have any test for get_number_of_image_patches to ensure it works correctly?

@zucchini-nlp
Copy link
Member Author

zucchini-nlp commented Jul 18, 2025

No, I didn't add tests for helper functions as they are not same for all models. Some models didn't need any helpers, some needed more. The only tests we have are on vLLM side

I can add a tiny test though I don't think anyone will touch these methods 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants