-
Notifications
You must be signed in to change notification settings - Fork 36
Changes on TimePicker not being reflected. #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This behavior is by design (and in the original JavaScript component as well). In my implementation, there's a line in if (TimePicker == true && AutoApply == true) AutoApply = false; This is because it's unclear when the selection is complete and the component should close (after selecting the hour, minute, start time, or end time?). Therefore, I don't see how AutoApply can be used effectively in TimePicker mode. There's an |
You are right in that AutoApply can't really be used when TimePicker is enabled. Exposing a TimeSelected event would suffice in my opinion and use case. Even without an Apply button I can use this new event to capture time changes and then trigger my own ValueChanged callback. |
Hi, I have added the |
OnSelectionStart and OnSelectionEnd will only be called when changing the dates, not when changing the time in the TimePicker.
This makes the component impossible to use with AutoApply, since it will never callback the correct time values.
One possible fix would be for TimeChanged, based on the parameter that is not null, to call OnSelectionStart or OnSelectionEnd after setting TStartDate/TEndDate.
The text was updated successfully, but these errors were encountered: