Merge pull request #26 from jeantimex/simplify-the-heightForRowAtIndexPath

Simplify the heightForRowAtIndexPath.

Author: jeantimex

README.md

@@ -49,6 +49,10 @@ override func viewDidLoad() {
 
   ...
 }
+
+override func tableView(_ tableView: UITableView, heightForRowAtIndexPath indexPath: NSIndexPath) -> CGFloat {
+  return UITableViewAutomaticDimension
+}
 ```
 
 #### Step 3. The Section Header ####
@@ -146,15 +150,15 @@ override func numberOfSectionsInTableView(in tableView: UITableView) -> Int {
 }
 ```
 
-and the number of rows in each section is:
+Here is the key ingredient of implementing the collapsible table section, if the section is collapsed, then that section should not have any row:
 
 ```swift
 override func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
     return sections[section].collapsed ? 0 : sections[section].items.count
 }
 ```
 
-Noticed that we don't need to render any cell for the collapsed section, this can improve the performance a lot if there are lots of cells in that section.
+Noticed that we don't need to render any cell for the collapsed section, this can improve the performance a lot if there are tons of cells in that section.
 
 Next, we use tableView's viewForHeaderInSection function to hook up our custom header:
 
@@ -187,15 +191,7 @@ In the above code, we use the plain `UITableViewCell`, if you would like to see
 
 #### Step 5. How to Toggle Collapse and Expand ####
 
-The idea is really simple, if a section's `collapsed` property is `true`, we set the height of the rows inside that section to be `0`, otherwise `UITableViewAutomaticDimension`!
-
-```swift
-override func tableView(_ tableView: UITableView, heightForRowAtIndexPath indexPath: NSIndexPath) -> CGFloat {
-  return sections[indexPath.section].collapsed ? 0 : UITableViewAutomaticDimension
-}
-```
-
-And here is the toggle function:
+The idea is pretty starightforward, reverse the `collapsed` flag for the section and tell the tableView to reload that section:
 
 ```swift
 extension CollapsibleTableViewController: CollapsibleTableViewHeaderDelegate {

ios-swift-collapsible-table-section/CollapsibleTableViewController.swift

@@ -54,7 +54,7 @@ extension CollapsibleTableViewController {
     }
 
     override func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
-        return sections[indexPath.section].collapsed ? 0 : UITableViewAutomaticDimension
+        return UITableViewAutomaticDimension
     }
 
     // Header