Change minification to remove mangling. v 2.0.3

Author: johnfmorton

changelog.md

@@ -2,6 +2,11 @@
 
 ## Changelog
 
+## [2.0.3] - 2018-07-30
+### Fixed
+- The JS minification settings were too aggressive and would break some banners. It's been ratched down to not manage variable names.
+- The default "script.js" file has also changed the function style from named functions to function declarations.
+
 ## [2.0.2] - 2018-07-30
 ### Fixed
 - Some dependencies were listed in "devDependencies" which meant they did not install from the production version of BAB. They've been moved to the correct spot in the package.json file.

generators/app/templates/_gulpfile.babel.js

@@ -52,19 +52,19 @@ const nowDate = new Date();
 
 const bannerMessageHtml = ['<!--',
   ' <%- openTag %> pkg.name <%- closeTag %> - <%- openTag %> pkg.description <%- closeTag %>',
-  ' * Build A Banner info: https://www.npmjs.com/package/generator-buildabanner',
   ' @version v<%- openTag %> pkg.version <%- closeTag %>',
   ' @date ' + (nowDate.getMonth() + 1) + "-" + nowDate.getDate() + "-" + nowDate.getFullYear() + " at " + nowDate.getHours() + ":" + nowDate.getMinutes() + ":" + nowDate.getSeconds(),
+  ' * Build A Banner info: https://www.npmjs.com/package/generator-buildabanner',
   ' -->',
   ' ',
   ''
 ].join('\n');
 
 const bannerMessageJsCss = ['/**',
   ' * <%- openTag %> pkg.name <%- closeTag %> - <%- openTag %> pkg.description <%- closeTag %>',
-  ' * Build A Banner info: https://www.npmjs.com/package/generator-buildabanner',
   ' * @version v<%- openTag %> pkg.version <%- closeTag %>',
   ' * @date ' + (nowDate.getMonth() + 1) + "-" + nowDate.getDate() + "-" + nowDate.getFullYear() + " at " + nowDate.getHours() + ":" + nowDate.getMinutes() + ":" + nowDate.getSeconds(),
+  ' * Build A Banner info: https://www.npmjs.com/package/generator-buildabanner',
   ' */',
   ' ',
   ''
@@ -94,14 +94,9 @@ function scripts() {
     .pipe(uglify({
       compress: {
         // compress options
-        drop_console: beautify
-      },
-      mangle: {
-        // mangle options
-        properties: {
-          // mangle property options
-        }
+        drop_console: true
       },
+      mangle: false,
       output: {
         beautify: beautify
       }

generators/app/templates/dev/_script_adwords.js

@@ -5,7 +5,7 @@
 var removeMeBABExample;
 
 //Function to run with any animations starting on load, or bringing in images etc
-bannerInit = function(){
+function bannerInit(){
     // adds class "loaded" to the body
     // document.getElementsByTagName('body')[0].className+=' loaded';
 
@@ -20,7 +20,7 @@ bannerInit = function(){
     anim();
 }
 
-anim = function(){
+function anim(){
     console.log('animating');
 
     // Example #1

generators/app/templates/dev/_script_dc.js

@@ -9,7 +9,7 @@ var bgExit;
 var removeMeBABExample;
 
 //Function to run with any animations starting on load, or bringing in images etc
-bannerInit = function(){
+function bannerInit{
     // adds class "loaded" to the body
     // document.getElementsByTagName('body')[0].className+=' loaded';
 
@@ -35,7 +35,7 @@ bannerInit = function(){
     anim();
 }
 
-anim = function(){
+function anim(){
     console.log('Banner animation has begun.');
 
     // Example #1
@@ -52,11 +52,11 @@ anim = function(){
 }
 
 //Add Event Listeners for DoubleClick
-addListeners = function() {
+function addListeners() {
     bgExit.addEventListener('click', bgExitHandler, false);
 }
 
-bgExitHandler = function(e) {
+function bgExitHandler(e) {
     //Call Exits
     Enabler.exit('HTML5_Background_Clickthrough');
 }

generators/app/templates/dev/_script_sizmek.js

@@ -9,7 +9,7 @@
 var removeMeBABExample;
 
 //Function to run with any animations starting on load, or bringing in images etc
-bannerInit = function(){
+function bannerInit(){
     // adds class "loaded" to the body
     // document.getElementsByTagName('body')[0].className+=' loaded';
 
@@ -27,7 +27,7 @@ bannerInit = function(){
     anim();
 }
 
-anim = function(){
+function anim(){
     console.log('animating');
 
     // Example #1

generators/app/templates/dev/_script_standard.js

@@ -9,7 +9,7 @@
 var removeMeBABExample;
 
 //Function to run with any animations starting on load, or bringing in images etc
-bannerInit = function(){
+function bannerInit(){
     // adds class "loaded" to the body
     // document.getElementsByTagName('body')[0].className+=' loaded';
 
@@ -27,7 +27,7 @@ bannerInit = function(){
     anim();
 }
 
-anim = function(){
+function anim(){
     console.log('animating');
 
     // Example #1

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "generator-buildabanner",
-  "version": "2.0.2",
+  "version": "2.0.3",
   "description": "Yeoman generator to help build a variety of HTML banners: Standard, Adwords, DoubleClick Studio or Sizmek.",
   "license": "MIT",
   "main": "app/index.js",