Follow proper package guidelines

[FilledStacks]

I just started using your package and see that I have to import every file separately for your notion package. There are 2 conventions you need to follow which is used by all packages.

1. Could you please update your package to export all required files properly so that we don't have too many dependencies on file imports in our classes. Currently for this small bit of code.

  Future<void> createPage({required String pageId}) {
    Page page = Page(
      parent: Parent.page(id: 'YOUR_PAGE_ID'), // <- page
      title: Text('NotionClient (v1): Page test'),
    );
  }

I have to import all of this

import 'package:notion_api/notion.dart';
import 'package:notion_api/notion/general/rich_text.dart';
import 'package:notion_api/notion/objects/pages.dart';
import 'package:notion_api/notion/objects/parent.dart';

It should only be

import 'package:notion_api/notion.dart';

To achieve this all you have to do is declare an export in your notion.dart file.

export 'notion/general/rich_text.dart';
export 'notion/objects/pages.dart';
export 'notion/objects/parent.dart';

2. Move private code into a folder called src. At the moment it's all accessible and when you do improve your code it will break all projects that use this. It's better to do it early.

[jonathangomz]

Thaaaaannnks, I will add this change for the next version that I have planned for this Monday 😊

I really really appreciate this suggestion because I'm new with all of this and I'm learning on the progress 😅

[hewcaw]

@jonathangomz, hey bro can you keep the terminologies (and the philosophy) the same with notion-sdk-js (NotionClient ➜ Client, ...database.fetch ➜ ...database.query, etc). I know it's unfair to you but I got some good reasons though. First, since the SDK just took the same terms from the Notion API. And second, JS is more popular than Dart so in case if anybody want to give Dart a try, their transition process is also a little bit easier.

[jonathangomz]

Hey, @soahyle, I don't know how the JS package is made but I will definitely take a look, thanks! 😊

[jonathangomz]

I already published a new beta version trying to use the same terminology as the other package so if you could check it to confirm if that was what you were telling me it could be of great help 😄 @soahyle

[hewcaw]

Look good bro, just the part notion.blocks.list, it should be notion.blocks.children.list since there are 2 ways to retrieve block, first retrieve a single block notion.blocks.retrieve and the previous part that I just wrote.

But really though I'm not that strict and an expect in this aspect. I told you this because beside my proposal, you could also save your time by using notion-sdk-js and try to port it into Dart and spend your time on developing your own wonderful features.

Anyway, I'm so sorry to tell you that I'm currently not using this package though since I tried to use Flutter Web with Vercel as a serverless function but vercel-dart doesn't support null safety yet so I have to use Node instead, right now I cannot testing the package usage. But still, thank you so much for your effort ❤️

[jonathangomz]

Oh don't worry, thanks for the help :)