This repository was archived by the owner on Nov 30, 2020. It is now read-only.
Throw meaningful errors when no harpstrata can be returned #12
Comments
js-jslog
pushed a commit
to js-jslog/harpguru-web
that referenced
this issue
May 12, 2020
I had to make quite a few changes lower down here because the harpstrata version which we are currently using only makes C & Db pitches available. Errors were occuring when running the tests with A & Bb as we already had in the PitchButtons component, presumably because an error was occurring in harpstrata trying to handle a value which it doesn't have a mapping for. I have raised an issue for errors to be handled deliberately in harpstrata - js-jslog/harpstrata#12
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What happens if we provide pitch, apparatus or degree ids which aren't actually active at the moment in harpstrata despite being part of the PozitionsIds enum for example? Is what happens suitable for a graceful failure in the calling app?
The text was updated successfully, but these errors were encountered: