fix: show correct number of peers after switching accounts

Author: jsiebens

internal/domain/machine.go

@@ -471,14 +471,14 @@ func (r *repository) ListMachineByTailnet(ctx context.Context, tailnetID uint64)
 	return machines, nil
 }
 
-func (r *repository) ListMachinePeers(ctx context.Context, tailnetID uint64, key string) (Machines, error) {
-	var machines = []Machine{}
+func (r *repository) ListMachinePeers(ctx context.Context, tailnetID uint64, machineID uint64) (Machines, error) {
+	var machines []Machine
 
 	tx := r.withContext(ctx).
 		Preload("Tailnet").
 		Joins("User").
 		Joins("User.Account").
-		Where("machines.tailnet_id = ? AND machines.machine_key <> ?", tailnetID, key).
+		Where("machines.tailnet_id = ? AND machines.id <> ?", tailnetID, machineID).
 		Order("machines.id asc").
 		Find(&machines)
 

internal/domain/repository.go

@@ -67,7 +67,7 @@ type Repository interface {
 	CountMachineByTailnet(ctx context.Context, tailnetID uint64) (int64, error)
 	DeleteMachineByTailnet(ctx context.Context, tailnetID uint64) error
 	DeleteMachineByUser(ctx context.Context, userID uint64) error
-	ListMachinePeers(ctx context.Context, tailnetID uint64, key string) (Machines, error)
+	ListMachinePeers(ctx context.Context, tailnetID uint64, machineID uint64) (Machines, error)
 	ListInactiveEphemeralMachines(ctx context.Context, checkpoint time.Time) (Machines, error)
 	SetMachineLastSeen(ctx context.Context, machineID uint64) error
 

internal/mapping/poll_net_mapper.go

@@ -81,7 +81,7 @@ func (h *PollNetMapper) CreateMapResponse(ctx context.Context, delta bool) (*Map
 	syncedPeerIDs := map[uint64]bool{}
 
 	if !h.req.OmitPeers {
-		candidatePeers, err := h.repository.ListMachinePeers(ctx, m.TailnetID, m.MachineKey)
+		candidatePeers, err := h.repository.ListMachinePeers(ctx, m.TailnetID, m.ID)
 		if err != nil {
 			return nil, err
 		}

tests/switch_test.go

@@ -34,6 +34,7 @@ func TestSwitchAccounts(t *testing.T) {
 		require.NoError(t, node.WaitFor(tsn.Connected()))
 		require.NoError(t, node.Check(tsn.HasUser("[email protected]")))
 		require.NoError(t, node.Check(tsn.HasName("switch-1")))
+		require.NoError(t, node.Check(tsn.PeerCount(1)))
 
 		machines := s.ListMachines(tailnet.Id)
 		require.Equal(t, 2, len(machines))