Skip to content
This repository was archived by the owner on Apr 6, 2022. It is now read-only.

Commit 8e6d493

Browse files
author
Jason Snow
authored
Merge pull request #10 from jyksnw/development
Prepare release of v0.1.2
2 parents c9022ca + 3b27174 commit 8e6d493

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from setuptools import setup
44

5-
VERSION = '0.1.1'
5+
VERSION = '0.1.2'
66

77

88
def read(file_name):

youversion/youversion.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
from datetime import datetime
33
from os import path, getcwd
44
from shutil import copyfileobj
5+
from posixpath import join as urljoin
56

67
import requests
78

@@ -338,7 +339,7 @@ def _get(self, resource: str, *args, **kwargs):
338339
:return: json response
339340
"""
340341

341-
url = path.join(API.BASE_URL, resource)
342+
url = urljoin(API.BASE_URL, resource)
342343
response = requests.get(url, headers=self._header, **kwargs)
343344

344345
if response.ok:
@@ -420,9 +421,6 @@ def get_all_verse_of_the_days(self, limit: int = 366, page: int = 1) -> Tuple[bo
420421
list of VerseOfTheDay objects
421422
"""
422423
json = self._get('verse_of_the_day', params={'version_id': self.bible_version.id})
423-
if not json or 'data' not in json:
424-
return False, 0, None
425-
426424
votds = [VerseOfTheDay(bible_version=self.bible_version, json=data) for data in json.get('data', [])]
427425
next_page = json.get('next_page', False)
428426
page_size = json.get('page_size', len(votds))

0 commit comments

Comments
 (0)