Skip to content

Commit 5b83ca1

Browse files
committed
fix needUpdate currentVersion bug
1 parent bc58f48 commit 5b83ca1

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/needUpdate.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ function needUpdateDeprecated(depth = Infinity, delimiter = ".") {
6767
}
6868

6969
function checkIfUpdateNeeded(currentVersion, latestVersion, option) {
70-
currentVersion = getVersionNumberArray(currentVersion, option.depth, option.delimiter);
70+
let currentVersionArr = getVersionNumberArray(currentVersion, option.depth, option.delimiter);
7171
let latestVersionArr = getVersionNumberArray(latestVersion, option.depth, option.delimiter);
7272

7373
const needed = {
@@ -82,13 +82,13 @@ function checkIfUpdateNeeded(currentVersion, latestVersion, option) {
8282
};
8383

8484
for (let i = 0; i < option.depth; i++) {
85-
if (!latestVersionArr[i] && !currentVersion[i]) {
85+
if (!latestVersionArr[i] && !currentVersionArr[i]) {
8686
return Promise.resolve(notNeeded);
8787
}
88-
if (!currentVersion[i]) {
88+
if (!currentVersionArr[i]) {
8989
return Promise.resolve(needed);
9090
}
91-
if (latestVersionArr[i] > currentVersion[i]) {
91+
if (latestVersionArr[i] > currentVersionArr[i]) {
9292
return Promise.resolve(needed);
9393
}
9494
}

0 commit comments

Comments
 (0)