Skip to content

Commit 5fe34a9

Browse files
RockawearRockfeller Fixe
andauthored
Grant create events permissions to Controller (#2616)
* Grant get/patch permissions for SparkConnect CRD to hook ClusterRole (#2605) * Grant get/patch permissions for SparkConnect CRD to hook ClusterRole Signed-off-by: Yi Chen <[email protected]> * Update Helm unit tests Signed-off-by: Yi Chen <[email protected]> --------- Signed-off-by: Yi Chen <[email protected]> <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, check our contributor guidelines: https://www.kubeflow.org/docs/about/contributing 2. To know more about how to develop with the Spark operator, check the developer guide: https://www.kubeflow.org/docs/components/spark-operator/developer-guide/ 3. If you want *faster* PR reviews, check how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews 4. Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste! --> ## Purpose of this PR <!-- Provide a clear and concise description of the changes. Explain the motivation behind these changes and link to relevant issues or discussions. --> **Proposed changes:** - <Change 1> - <Change 2> - <Change 3> ## Change Category <!-- Indicate the type of change by marking the applicable boxes. --> - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] Feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that could affect existing functionality) - [ ] Documentation update ### Rationale <!-- Provide reasoning for the changes if not already covered in the description above. --> ## Checklist <!-- Before submitting your PR, please review the following: --> - [ ] I have conducted a self-review of my own code. - [ ] I have updated documentation accordingly. - [ ] I have added tests that prove my changes are effective or that my feature works. - [ ] Existing unit tests pass locally with my changes. ### Additional Notes <!-- Include any additional notes or context that could be helpful for the reviewers here. --> Signed-off-by: Rockawear <[email protected]> * updated to apply feedback from review Signed-off-by: Rockfeller Fixe <[email protected]> --------- Signed-off-by: Rockawear <[email protected]> Signed-off-by: Rockfeller Fixe <[email protected]> Co-authored-by: Rockfeller Fixe <[email protected]>
1 parent 6a40bf3 commit 5fe34a9

File tree

1 file changed

+9
-0
lines changed
  • charts/spark-operator-chart/templates/controller

1 file changed

+9
-0
lines changed

charts/spark-operator-chart/templates/controller/rbac.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,15 @@ rules:
9696
{{- end }}
9797
{{- if has .Release.Namespace .Values.spark.jobNamespaces }}
9898
{{ include "spark-operator.controller.policyRules" . }}
99+
{{- else }}
100+
- apiGroups:
101+
- ""
102+
resources:
103+
- events
104+
verbs:
105+
- create
106+
- update
107+
- patch
99108
{{- end }}
100109
---
101110

0 commit comments

Comments
 (0)