Skip to content

Commit 29ee524

Browse files
committed
Add CACertificateValidityPeriod to Kubeadmconfig
1 parent 7f713bb commit 29ee524

19 files changed

+68
-20
lines changed

api/bootstrap/kubeadm/v1beta1/conversion_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ func hubKubeadmConfigSpec(in *bootstrapv1.KubeadmConfigSpec, c randfill.Continue
130130
// Drop the field to avoid round trip errors as it exists only in v1beta2.
131131
if in.ClusterConfiguration != nil {
132132
in.ClusterConfiguration.CertificateValidityPeriodSeconds = nil
133+
in.ClusterConfiguration.CACertificateValidityPeriodSeconds = nil
133134
}
134135
}
135136

api/bootstrap/kubeadm/v1beta1/zz_generated.conversion.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/bootstrap/kubeadm/v1beta2/kubeadm_types.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,9 +174,14 @@ type ClusterConfiguration struct {
174174
FeatureGates map[string]bool `json:"featureGates,omitempty"`
175175

176176
// certificateValidityPeriodSeconds specifies the validity period for a non-CA certificate generated by kubeadm.
177-
// Default value: 756,864,000 seconds, 8760h (365 days * 24 hours = 1 year)
177+
// Default value: 756,864,000 seconds -> 8760h (365 days * 24 hours = 1 year)
178178
// +optional
179179
CertificateValidityPeriodSeconds *int32 `json:"certificateValidityPeriodSeconds,omitempty"`
180+
181+
// caCertificateValidityPeriodSeconds specifies the validity period for a CA certificate generated by kubeadm.
182+
// Default value: 756,864,000 seconds -> 87600h (365 days * 24 hours * 10 = 10 years)
183+
// +optional
184+
CACertificateValidityPeriodSeconds *int32 `json:"caCertificateValidityPeriodSeconds,omitempty"`
180185
}
181186

182187
// ControlPlaneComponent holds settings common to control plane component of the cluster.

api/bootstrap/kubeadm/v1beta2/zz_generated.deepcopy.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/controlplane/kubeadm/v1beta1/conversion_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ func hubKubeadmConfigSpec(in *bootstrapv1.KubeadmConfigSpec, c randfill.Continue
106106
}
107107
if in.ClusterConfiguration != nil {
108108
in.ClusterConfiguration.CertificateValidityPeriodSeconds = nil
109+
in.ClusterConfiguration.CACertificateValidityPeriodSeconds = nil
109110
}
110111
}
111112

bootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigs.yaml

Lines changed: 7 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigtemplates.yaml

Lines changed: 7 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bootstrap/kubeadm/types/upstreamv1beta3/conversion_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,4 +201,5 @@ func hubClusterConfigurationFuzzer(obj *bootstrapv1.ClusterConfiguration, c rand
201201
c.FillNoCustom(obj)
202202

203203
obj.CertificateValidityPeriodSeconds = nil
204+
obj.CACertificateValidityPeriodSeconds = nil
204205
}

bootstrap/kubeadm/types/upstreamv1beta3/zz_generated.conversion.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bootstrap/kubeadm/types/upstreamv1beta4/conversion.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ func Convert_upstreamv1beta4_ClusterConfiguration_To_v1beta2_ClusterConfiguratio
6767
return err
6868
}
6969
out.CertificateValidityPeriodSeconds = clusterv1.ConvertToSeconds(in.CertificateValidityPeriod)
70+
out.CACertificateValidityPeriodSeconds = clusterv1.ConvertToSeconds(in.CACertificateValidityPeriod)
7071
return nil
7172
}
7273

@@ -230,5 +231,6 @@ func Convert_v1beta2_ClusterConfiguration_To_upstreamv1beta4_ClusterConfiguratio
230231
return err
231232
}
232233
out.CertificateValidityPeriod = clusterv1.ConvertFromSeconds(in.CertificateValidityPeriodSeconds)
234+
out.CACertificateValidityPeriod = clusterv1.ConvertFromSeconds(in.CACertificateValidityPeriodSeconds)
233235
return nil
234236
}

0 commit comments

Comments
 (0)