-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Open
Labels
area/machinedeploymentIssues or PRs related to machinedeploymentsIssues or PRs related to machinedeploymentskind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.priority/backlogHigher priority than priority/awaiting-more-evidence.Higher priority than priority/awaiting-more-evidence.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Description
Before 1.11, machine deployment wasn't updating replica counters of phase during deletion
With v1.11 this was fixed, but when deleting a machine deployment phase is scalingDown which is correct except for when replicas = 0 and deletion is blocked by a finalizer.
We can consider adding a Deleting phase for machine deployments to use at the end of the deletion process (or during the entire deletion process).
However, doing this now has the downside to figure out what to do for up/down conversions, so I think we should defer to when v1beta1 is removed (or to when all the priority work for v1beta2 is completed)
Metadata
Metadata
Assignees
Labels
area/machinedeploymentIssues or PRs related to machinedeploymentsIssues or PRs related to machinedeploymentskind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.priority/backlogHigher priority than priority/awaiting-more-evidence.Higher priority than priority/awaiting-more-evidence.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.