Skip to content

Commit 203a91c

Browse files
committed
Add risks and mitigations and phases
1 parent 0022f89 commit 203a91c

File tree

1 file changed

+19
-2
lines changed
  • keps/sig-storage/5030-attach-limit-autoscaler

1 file changed

+19
-2
lines changed

keps/sig-storage/5030-attach-limit-autoscaler/README.md

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,9 @@ Scheduler changes can only be merged after cluster-autoscaler changes has been G
148148

149149
### Risks and Mitigations
150150

151+
As mentioned above, there is a risk associated with scheduler changes being merged before cluster-autoscaler changes can be merged, but we want to mitigate
152+
this by making sure cluster-autoscaler changes are merged first and has N+2 window before scheduler changes can be made GA.
153+
151154
<!--
152155
What are the risks of this proposal, and how do we mitigate? Think broadly.
153156
For example, consider both security and how this will impact the larger
@@ -288,8 +291,16 @@ We will add tests that validate both scaling from 0 and scaling from 1 use cases
288291

289292
#### Alpha
290293

291-
- All of the planned code changes for alpha will be done in cluster-autoscaler and not in k/k repository.
292-
- Initial e2e tests completed and enabled
294+
##### Phase-1
295+
296+
- This is MVP of cnhanges in cluster-autoscaler.
297+
- All of the planned code changes for Phase1- alpha will be done in cluster-autoscaler and not in k/k repository.
298+
We plan to impelemnt changes in cluster-autoscaler so as it can consider volume limits when scaling cluster.
299+
300+
##### Phase-2
301+
- Make changes in `kube-scheduler` so as it can stop scheduling of pods that require CSI volume if underlying CSI volume is not installed on the node.
302+
- Initial e2e tests completed and enabled.
303+
293304

294305
<!---
295306
#### Beta
@@ -324,6 +335,12 @@ in back-to-back releases.
324335

325336
### Upgrade / Downgrade Strategy
326337

338+
For the case of newer scheduler running with older autoscaler, we propose that `VolumeLimitScaling` feature
339+
should be disabled in the scheduler.
340+
341+
Upgrade and downgrade of `cluster-autoscaler` should be straightforward since there are no API changes
342+
involved and it just means the feature will stop working once downgraded.
343+
327344
<!--
328345
If applicable, how will the component be upgraded and downgraded? Make sure
329346
this is in the test plan.

0 commit comments

Comments
 (0)