Skip to content

Commit 762bd99

Browse files
committed
Update the KEP with clarify around localhost probes
Signed-off-by: Surya Seetharaman <[email protected]>
1 parent 63d4f6f commit 762bd99

File tree

1 file changed

+8
-0
lines changed
  • keps/sig-auth/4940-psa-block-host-field-in-probes

1 file changed

+8
-0
lines changed

keps/sig-auth/4940-psa-block-host-field-in-probes/README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,14 @@ probes with the Host field set when using the (about to be deprecated) API.
112112
This is implemented by [kubernetes PR 125271](https://github.com/kubernetes/kubernetes/pull/125271)
113113
that does exactly that.
114114

115+
NOTE: Given there is still a use case where admins might be deploying the apiserver
116+
or any controlplane host-networked pod service to have probes with `.Host` field set to
117+
localhost (127.0.0.1). This is because there could be firewall rules blocking access to public nodeIP
118+
for good reasons. Hence we would continue to allow for this use case meaning the only values
119+
allowed on the `.Host` field would be `127.0.0.1` and `::1`. See [this snippet] for example.
120+
121+
[this snippet]: https://github.com/kubernetes/kops/blob/5dd2f468b46fda43f3a63ba1e6dc7c55c21919eb/nodeup/pkg/model/kube_apiserver.go#L603
122+
115123
### Risks and Mitigations
116124

117125
There might be users who depend on the `Host` field in

0 commit comments

Comments
 (0)