Remove post-hero block and some more-hero block #50330
Open
+1
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
SayakMukhopadhyay
force-pushed
the
hero-rework
branch
3 times, most recently
from
3a0e3ed to
9b98849
Compare
SayakMukhopadhyay
force-pushed
the
hero-rework
branch
from
9b98849 to
baabab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes some template blocks that are not required anymore.
post-heroblock is removed from_default/baseof.htmlas its an emptyblockand is not defined anywhere else.hero-moreis removed fromblog/baseof.htmlanddocs/baseof.htmlas they are empty blocks and not defined anywhere else.hero-moredefinition is removed fromdocs/single.htmlas that block is only applicable when.IsHomeis true but it's never true for any content applicable for the docs/single layout.Issue
Closes: #50317
Helps with #41171
/area web-development
/kind cleanup
/hold