Skip to content

[BUG] typo in dss parser for Vsource wrong assignment of x1 instead of x0 #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MohamedNumair opened this issue May 2, 2025 · 0 comments · May be fixed by #487
Open

[BUG] typo in dss parser for Vsource wrong assignment of x1 instead of x0 #486

MohamedNumair opened this issue May 2, 2025 · 0 comments · May be fixed by #487

Comments

@MohamedNumair
Copy link

In src/data_model/dss/edge_constructors.jl , the imaginary value of :puz0 is incorrectly assigned to x1 instead of x0.

PowerModelsDistribution.jl/src/data_model/dss/edge_constructors.jl

Line 308 in 3014d49

vsource.x1 = imag(puz0) * Zbase

MohamedNumair added a commit to MohamedNumair/PowerModelsDistribution.jl that referenced this issue May 2, 2025
@MohamedNumair
FIX: typo in dss parser for Vsource
e4fe1b3 
FIX: typo in dss parser for Vsource

`vsource.x1 = imag(puz0) * Zbase`

should be

`vsource.x0 = imag(puz0) * Zbase`

Resolves lanl-ansi#486
@MohamedNumair MohamedNumair linked a pull request May 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX: typo in dss parser for Vsource MohamedNumair/PowerModelsDistribution.jl
1 participant
@MohamedNumair