[12.x] Pipeline::withinTransaction() accepts connection (#56550)

* pipeline transaction accepts connection

* tests

* Update PipelineTransactionTest.php

* fix up

Author: cosmastech

src/Illuminate/Pipeline/Pipeline.php

@@ -51,7 +51,7 @@ class Pipeline implements PipelineContract
     /**
      * Indicates whether to wrap the pipeline in a database transaction.
      *
-     * @var bool
+     * @var string|null|\UnitEnum|false
      */
     protected $withinTransaction = false;
 
@@ -130,8 +130,8 @@ public function then(Closure $destination)
         );
 
         try {
-            return $this->withinTransaction
-                ? $this->getContainer()->make('db')->transaction(fn () => $pipeline($this->passable))
+            return $this->withinTransaction !== false
+                ? $this->getContainer()->make('db')->connection($this->withinTransaction)->transaction(fn () => $pipeline($this->passable))
                 : $pipeline($this->passable);
         } finally {
             if ($this->finally) {
@@ -257,10 +257,10 @@ protected function pipes()
     /**
      * Execute each pipeline step within a database transaction.
      *
-     * @param  bool  $withinTransaction
+     * @param  string|null|\UnitEnum|false  $withinTransaction
      * @return $this
      */
-    public function withinTransaction(bool $withinTransaction = true)
+    public function withinTransaction($withinTransaction = null)
     {
         $this->withinTransaction = $withinTransaction;
 

tests/Pipeline/PipelineTransactionTest.php

@@ -9,23 +9,56 @@
 use Illuminate\Support\Facades\Event;
 use Illuminate\Support\Facades\Pipeline;
 use Orchestra\Testbench\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 class PipelineTransactionTest extends TestCase
 {
     public function testPipelineTransaction()
     {
         Event::fake();
 
-        $result = Pipeline::withinTransactions()
+        $result = Pipeline::withinTransaction()
             ->send('some string')
-            ->through([function ($value, $next) {
-                return $next($value);
-            }])
+            ->through([
+                fn ($value, $next) => $next($value),
+                fn ($value, $next) => $next($value),
+            ])
             ->thenReturn();
 
         $this->assertEquals('some string', $result);
-        Event::assertDispatched(TransactionBeginning::class);
-        Event::assertDispatched(TransactionCommitted::class);
+        Event::assertDispatchedTimes(TransactionBeginning::class, 1);
+        Event::assertDispatchedTimes(TransactionCommitted::class, 1);
+    }
+
+    public static function transactionConnectionDataProvider(): array
+    {
+        return [
+            'unit enum' => [EnumForPipelineTransactionTest::DEFAULT, 'testing'],
+            'string' => ['testing', 'testing'],
+            'null' => [null, 'testing2'],
+        ];
+    }
+
+    #[DataProvider('transactionConnectionDataProvider')]
+    public function testConnection($connection, $connectionName)
+    {
+        Event::fake();
+        config(['database.connections.testing2' => config('database.connections.testing')]);
+        config(['database.default' => 'testing2']);
+
+        $result = Pipeline::withinTransaction($connection)
+            ->send('some string')
+            ->through([
+                function ($value, $next) {
+                    return $next($value);
+                }
+            ])
+            ->thenReturn();
+
+        $this->assertEquals('some string', $result);
+        Event::dispatched(TransactionBeginning::class, function(TransactionBeginning $event) use ($connectionName) {
+            return $event->connection === $connectionName;
+        });
     }
 
     public function testExceptionThrownRollsBackTransaction()
@@ -34,7 +67,7 @@ public function testExceptionThrownRollsBackTransaction()
 
         $finallyRan = false;
         try {
-            Pipeline::withinTransactions()
+            Pipeline::withinTransaction()
                 ->send('some string')
                 ->through([
                     function ($value, $next) {
@@ -54,3 +87,8 @@ function ($value, $next) {
         Event::assertDispatched(TransactionRolledBack::class);
     }
 }
+
+enum EnumForPipelineTransactionTest: string
+{
+    case DEFAULT = 'testing';
+}