-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix-layer5-maximum-width #6382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix-layer5-maximum-width #6382
Conversation
Signed-off-by: abhi2002dhi <[email protected]>
🚀 Preview for commit d051dc7 at: https://67f7cb757999719b4c9c4e07--layer5.netlify.app |
@dhimanAbhi Add it as an agenda item to the meeting minutes, if you would :) |
🚀 Preview for commit 9f12872 at: https://67fcc99efc8949c1d291e5c6--layer5.netlify.app |
As agreed in the sites meeting today, this is for now on |
@@ -2,6 +2,8 @@ import styled from "styled-components"; | |||
|
|||
const Banner1SectionWrapper = styled.section` | |||
display: none; | |||
max-width: 1170px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please avoid just adding a random width. This will not fix the issue but will be overhead as maintaining. I am sure this will again have issues in future because we are not fixing the root issue but just silently fixing it. Use like some width: 100%;
and then set max or min width based on responsiveness or use flex container styles please
Description
This PR fixes #6366
This PR addresses inconsistent maximum content widths across various sections of the Layer5 homepage, which previously resulted in an uneven and unprofessional layout.
Notes for Reviewers
Signed commits