Epmldi 1429 (#2)

* Initial commit

* edit molecule settings

* edit molecule settings

* edit gitlab-ci

* changed travis link

* test travis ci

* readme

* edit molecule settings for aws and epc

* fixed "too many spaces.." and "too many blank lines"

* fixed "too many spaces.." and "too many blank lines"

* Update Readme to change ci status tag

* fixed "too many spaces.." and "too many blank lines"

* fixed "too many spaces.." and "too many blank lines"

* add loop control

* fixed wrong indentation

* fixed wrong indentation

* fix lint

* fixed lint

* fix lint

* fix lint

* fix lint

* fix lint

* fix lint

* fix lint

* fix playbook

* Fix trailing-spaces

* Add debugs

* fix playbook

* change gpgkey for mysql

* add update_cache

* add update_cache

* change packages

* change packages

* add key

* fix syntax problem

* fix syntax problem

* delete systemd

* fix: 'mysql_replication_master' is undefined

* fix lint

* comment no_log for debug

* fix lint

* fix lint

* debug mysql hosts

* add host_all in mysql_user

* delete debug

* fix: update mysql root

* add "find temporary password"

* add debug  file /var/log/mysqld.log

* add debug file /var/log/mysqld.log

* define mysql_log in default

* fix logs file

* fix logs

* add handler

* fix lint

* fix lint

* add slurp

* add regex

* fix lint

* set default password for mysql root

* change place for create main log file

* fix password

* fix password

* fix lint

* debug mysql root password

* Test colors

* debug password

* fix password

* fix password

* test gitlab overrides

* fix password

* fix password

* Test travis coloring

* Test global env var

* Test unbuffer

* Fix lint

* Change webhook

* Remove env vars

* Remove unbuffered

* Test ansible-lint in molecule

* Test ansible-lint arguments

* Test full debug

* Test additional options

* Run ansible-lint

* Change ansible-lint arguments

* fix password

* fix password

* fix some errors

* fix Python libraries

* fix password

* fix lint

* fix few errors

* fix additional parameters

* fix lint

* fix lint

* fix lint

* fix lint

* fix lint

* edit default variables

* fix last time

* add skip lint for task change password

* fix lint

* fix lint

* fix default password root

* add general log

* Change root password reset handling

* Fix pytest version

* Add AWS tests

* Add EPC tests

* Add centos6 tests

* Change molecule.yml

* Turn on log

* Change docker image for centos6

* Change groups name

* Fix prepare playbook

* Tests without root

* Return become:True

* Change shape

* Remove create datadir step to meet idempotence

* Remove create datadir

* Add webhooks

* add additional parameters in template

* edit secure settings

* fix spelling mistake

* fix additional_parameters

* fix "Remove file reset.sql"

* test additional_parameters

* edit "Copy my.cnf global MySQL configuration."

* fix my.cnf template

* Add molecule scenarios for different mysql versions

* Change scenarios to avoid duplicates

* Lint fix: new line character at the end of file

* fix for mysql 5.6

* fix readme

* fix mariadb

* Fix for 5.5 and 5.6

* change readme

* Test mariadb

* Fix molecule config

* Test docker config

* Fix molecule.cfg

* Fix lint

* Try ansible colors

* Fix yaml

* test ANSIBLE_FORCE_COLOR

* Test tput

* Try force-color

* Test ANSIBLE_FORCE_COLOR

* Adjust gitlab-ci

* Change molecule

* Add env parameter to molecule

* Enable cloud tests

* Test version 5.5

* Fix new line character at the end of file

* Tests mysql 5.6 docker

* change default settings

* change readme

* change readme

* Enable cloud tests

* Test AWS USEAST

* Test AWS-USEAST-2

* Revert changes

* Enable all cloud tests

* Test on AWS

* Full test with selinux

* Update Readme [skip ci]

* Update Readme

* edit default parametrs

* add quotes on task's name

* add author in meta [skip ci]

* edit meta [skip ci]

* edit meta [skip ci]

* change defaults

* add quotes in handlers

* Update Readme, meta and molecule playbooks

* edit variables [skip ci]

* edit template [skip ci]

* add when for mysql_python_packages

* fix error with  line

* fix msg: The PyMySQL or MySQL-python  module is required."

* add quotes

* fix variables

* add become

* edit readme

* add quotes

* add ""

* Test template

* Test template

* Test template

* Test block become

* Adjust become

* Test import_tasks

* Add blocks become

* Fix handler become

* Fix compare to empty string

* Test lint rules

* Test lint version

* Test pip2

* Test install from repo

* Test ansible-lint default rules

* Add config ansible-lint

* Test docker

* Test full path lint

* Test ansible-lint path

* Test lint for configure

* Test lint path

* Add ls debug

* ls debug

* Test lint errors

* Change ansible-lint call

* Add ansible-lint config

* Fix lint errors and enable docker test

* Enable cloud tests

* Update gitlab-ci to call ansibe-lint correctly

* Final fixes: syntax and lint

* MariaDB test

* Added badges to Readme, fixed quotes

Author: tgadiev

.gitlab-ci.yml

@@ -7,6 +7,7 @@ stages:
 before_script:
   - ansible --version
   - molecule --version
+  - ansible-lint --version
 
 variables:
   GET_SOURCES_ATTEMPTS: "5"
@@ -16,7 +17,8 @@ Ansible lint:
   before_script:
     - git clone https://github.com/lean-delivery/ansible-lint-rules.git ~/ansible-lint-rules
   script:
-    - ansible-lint -c .ansible-lint `find . -regex ".*\.\(yml\)"`
+    - ansible-lint . $(find . -name \*.yml) -c .ansible-lint
+
   after_script:
     - rm -rf ~/ansible-lint-rules
   tags:

.travis.yml

@@ -14,11 +14,13 @@ before_install:
   - git clone -b ${lint_version} https://github.com/lean-delivery/ansible-lint-rules.git ~/ansible-lint-rules
 
 install:
-  - pip install --upgrade ansible==2.5.* ansible-lint docker-py molecule==2.17 pyOpenSSL PyYAML pytest==3.7.4
+  - pip install --upgrade ansible==2.5.* docker-py molecule==2.17 pyOpenSSL PyYAML pytest==3.7.4
+  - pip install git+https://github.com/ansible/ansible-lint.git
   - ansible --version
+  - ansible-lint --version
 
 script:
-  - ansible-lint -c .ansible-lint `find . -regex ".*\.\(yml\)"`
+  - ansible-lint . $(find . -name \*.yml) -c .ansible-lint
   - molecule test -s default
 
 notifications:

README.md

@@ -1,6 +1,9 @@
 # Ansible Role: MySQL
 [![License](https://img.shields.io/badge/license-Apache-green.svg?style=flat)](https://raw.githubusercontent.com/lean-delivery/ansible-role-mysql/master/LICENSE)
-[![Build Status](https://travis-ci.org/lean-delivery/ansible-role-mysql.svg?branch=master)](https://travis-ci.org/lean-delivery/ansible-role-mysql)
+[![Build Status](https://travis-ci.org/lean-delivery/ansible-role-mysql.svg)](https://travis-ci.org/lean-delivery/ansible-role-mysql)
+[![Galaxy](https://img.shields.io/badge/galaxy-lean_delivery.mysql-blue.svg)](https://galaxy.ansible.com/lean_delivery/mysql)
+![Ansible](https://img.shields.io/ansible/role/d/35413.svg)
+![Ansible](https://img.shields.io/badge/dynamic/json.svg?label=min_ansible_version&url=https%3A%2F%2Fgalaxy.ansible.com%2Fapi%2Fv1%2Froles%2F35413%2F&query=$.min_ansible_version)
 
 ## Summary
 

handlers/mysql_restart.yml

@@ -3,7 +3,7 @@
   block:
     - name: "Stop MySQL"
       service:
-        name: '{{ mysql_service_name }}'
+        name: "{{ mysql_service_name }}"
         state: stopped
 
     - name: "Wait until the lock file is removed"
@@ -13,14 +13,14 @@
 
     - name: "Start mysql"
       service:
-        name: '{{ mysql_service_name }}'
+        name: "{{ mysql_service_name }}"
         state: started
   become: True
 
 - name: "Wait for service to be ready"
   wait_for:
-    port: '{{ mysql_port }}'
-    host: '{{ mysql_bind_address }}'
+    port: "{{ mysql_port }}"
+    host: "{{ mysql_bind_address }}"
     connect_timeout: 3
     delay: 3
     timeout: 30

tasks/configure.yml

@@ -5,9 +5,9 @@
       template:
         src: my.cnf.j2
         dest: "{{ mysql_config_file }}"
-        owner: "root"
-        group: "root"
-        mode: "0644"
+        owner: root
+        group: root
+        mode: 0644
         force: "{{ overwrite_global_mycnf }}"
       register: mysql_config
       notify: restart mysql
@@ -16,9 +16,9 @@
       file:
         path: "{{ mysql_pid_file | dirname }}"
         state: directory
-        owner: "mysql"
-        group: "mysql"
-        mode: "0755"
+        owner: mysql
+        group: mysql
+        mode: 0755
 
     - name: "Clear InnoDB logs"
       include_tasks: clear_innodb_logs.yml
@@ -28,18 +28,18 @@
       file:
         path: "{{ mysql_config_include_dir }}"
         state: directory
-        owner: "root"
-        group: "root"
-        mode: "0755"
+        owner: root
+        group: root
+        mode: 0755
       when: mysql_config_include_files | length
 
     - name: "Create slow query log file (if configured)."
       file:
         path: "{{ mysql_slow_query_log_file }}"
         state: touch
-        owner: "mysql"
+        owner: mysql
         group: "{{ mysql_log_file_group }}"
-        mode: "0640"
+        mode: 0640
       register: touch_slowlog
       changed_when: touch_slowlog.diff.before.state != "file"
       when: mysql_slow_query_log_enabled
@@ -48,16 +48,15 @@
       file:
         path: "{{ mysql_log_error }}"
         state: touch
-        owner: "mysql"
+        owner: mysql
         group: "{{ mysql_log_file_group }}"
-        mode: "0640"
-        seuser: "system_u"
-        serole: "object_r"
-        setype: "mysqld_log_t"
-        selevel: "s0"
+        mode: 0640
+        seuser: system_u
+        serole: object_r
+        setype: mysqld_log_t
+        selevel: s0
       register: touch_log
       changed_when: touch_log.diff.before.state != "file"
-      when: mysql_log_error != ""
 
     - name: "Start MySQL service"
       service:

tasks/databases_and_users.yml

@@ -1,5 +1,5 @@
 ---
-- name: "Ensure MySQL databases are present."
+- name: 'Ensure MySQL databases are present.'
   mysql_db:
     name: "{{ item.name }}"
     collation: "{{ item.collation | default('utf8_general_ci') }}"
@@ -10,7 +10,7 @@
     login_password: "{{ mysql_root_password }}"
   with_items: "{{ mysql_databases }}"
 
-- name: "Ensure MySQL users are present."
+- name: 'Ensure MySQL users are present.'
   mysql_user:
     name: "{{ item.name }}"
     host: "{{ item.host | default('localhost') }}"

tasks/secure-installation.yml

@@ -1,11 +1,11 @@
 ---
-# Reset default passwort for root didn't work with module mysql_user,
+# Reset default passwort for root didn"t work with module mysql_user,
 # that why we use this block
 - name: "Make new mysql admin user"
   block:
     - name: "Check mysql version"
       mysql_variables:
-        variable: "version"
+        variable: version
         login_user: "{{ mysql_root_username }}"
         login_password: "{{ mysql_root_password }}"
       register: mysql_version_out
@@ -16,7 +16,7 @@
 
     - name: "Out mysql_version"
       debug:
-        var: "mysql_version"
+        var: mysql_version
   rescue:
     - name: "Clear InnoDB logs and restart MySQL in skip-grant-tables mode"
       block:
@@ -25,11 +25,11 @@
 
         - name: "Copy init.cnf for skip-grant-tables mode"
           template:
-            src: "init.cnf.j2"
+            src: init.cnf.j2
             dest: "{{ mysql_config_file }}"
-            owner: "root"
-            group: "root"
-            mode: "0644"
+            owner: root
+            group: root
+            mode: 0644
             force: True
 
         - name: "Start mysql with skip-grant-tables"
@@ -48,7 +48,7 @@
 
     - name: "Check mysql version"
       mysql_variables:
-        variable: "version"
+        variable: version
       register: mysql_version_out
 
     - name: "Set mysql version"
@@ -57,19 +57,19 @@
 
     - name: "Out mysql_cli_version"
       debug:
-        var: "mysql_version"
+        var: mysql_version
 
     - name: "Copy reset.sql for root reset"
       template:
-        src: "reset.sql.j2"
-        dest: "/tmp/reset.sql"
+        src: reset.sql.j2
+        dest: /tmp/reset.sql
         force: True
 
     - name: "Reset root credentials"
       mysql_db:
-        name: "mysql"
+        name: mysql
         state: import
-        target: "/tmp/reset.sql"
+        target: /tmp/reset.sql
 
     - name: "Clear InnoDB logs and restart MySQL in normal mode"
       block:
@@ -78,11 +78,11 @@
 
         - name: "Copy my.cnf global MySQL configuration."
           template:
-            src: "my.cnf.j2"
+            src: my.cnf.j2
             dest: "{{ mysql_config_file }}"
-            mode: "0644"
-            owner: "root"
-            group: "root"
+            mode: 0644
+            owner: root
+            group: root
 
         - name: "Start mysql"
           service:
@@ -92,7 +92,7 @@
 
     - name: "Remove file reset.sql"
       file:
-        path: "/tmp/reset.sql"
+        path: /tmp/reset.sql
         state: absent
 
     - name: "Wait for service to be ready"
@@ -106,7 +106,7 @@
 - name: "Ensure default user is present."
   mysql_user:
     name: "{{ mysql_user_name }}"
-    host: "localhost"
+    host: localhost
     password: "{{ mysql_user_password }}"
     priv: "*.*:ALL,GRANT"
     state: present
@@ -117,15 +117,15 @@
 - name: "Copy .my.cnf file with password credentials."
   become: True
   template:
-    src: "user-my.cnf.j2"
+    src: user-my.cnf.j2
     dest: "{{ mysql_user_home }}/.my.cnf"
     owner: "{{ mysql_user_name }}"
-    mode: "0600"
+    mode: 0600
   when: mysql_user_name != mysql_root_username
 
 - name: "Update mysql root password for all root accounts"
   mysql_user:
-    name: "root"
+    name: root
     host_all: True
     password: "{{ mysql_root_password }}"
     check_implicit_admin: True
@@ -144,7 +144,7 @@
 
 - name: "Remove MySQL test database."
   mysql_db:
-    name: "test"
+    name: test
     state: absent
     login_user: "{{ mysql_root_username }}"
     login_password: "{{ mysql_root_password }}"

vars/RedHat-7-mariadb.yml

@@ -4,10 +4,9 @@ mysql_version: "latest"
 mysql_repo: "http://yum.mariadb.org/10.1/centos7-amd64"
 mysql_gpgkey: "https://yum.mariadb.org/RPM-GPG-KEY-MariaDB"
 mysql_packages:
-  - "mariadb"
   - "MariaDB-client"
   - "MariaDB-server"
-  - "mariadb-libs"
+
 mysql_python_packages:
   - "MySQL-python"
   - "perl-DBD-MySQL"