bug: PR Checklist Item Marked as Resolved, but Button Still Says “Resolve”

[rappm]

Describe the bug

After checking off unresolved PR checklist items flagged by Hephaestus, the status updates correctly, but the associated “Resolve” button does not change its label or state—it still shows “Resolve,” which is misleading and suggests the issue is still unresolved.

To reproduce

1. Create a PR with an incomplete checklist.
2. View flagged issues under Hephaestus analysis.
3. Check off all checklist items.
4. Observe that the issue appears resolved, but the Resolve button still says Resolve.

Environment

No response

Additional information

No response

Would you like to contribute a fix?

No

[dosubot]

Hi @rappm! I'm Dosu and I’m helping the Hephaestus team.

I couldn't find any existing issues or discussions about the 'Resolve' button not updating its label after resolving checklist items. Based on the code, the 'Resolve' button is implemented in the BadPracticeCard.tsx component as a dropdown menu, and its label always stays as "Resolve" regardless of the item's state. The resolved state is managed by the parent component, which updates the card or summary after an item is resolved, but the button itself doesn't change to indicate resolution—this is by design in the current implementation. If you expect the button to change its label or state after resolution, this would require a UI update to reflect the resolved status more clearly.
You can see the relevant implementation details in the BadPracticeCard.tsx and PullRequestBadPracticeCard.tsx components.

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}