Skip to content

Commit 12c0c8d

Browse files
authored
Merge pull request #5 from m-shule/dev
remove type for response
2 parents a338900 + f840eb0 commit 12c0c8d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.phpunit.result.cache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
C:37:"PHPUnit\Runner\DefaultTestResultCache":2452:{a:2:{s:7:"defects";a:0:{}s:5:"times";a:22:{s:106:"Mshule\LaravelPipes\Tests\PipeRequestTest::a_not_found_pipe_exception_is_thrown_if_no_controller_was_found";d:0.119;s:73:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_returns_a_ok_200er_response";d:0.03;s:100:"Mshule\LaravelPipes\Tests\PipeRequestTest::the_response_can_be_changed_through_the_response_resolver";d:0.017;s:122:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_fires_an_incoming_pipe_request_event_when_a_request_is_handled_by_the_kernel";d:0.017;s:125:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_fires_an_incoming_pipe_response_event_when_a_response_is_returned_by_the_kernel";d:0.017;s:76:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_to_callbacks";d:0.018;s:77:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_matches_everything_to_lowercase";d:0.018;s:85:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_to_controller_actions";d:0.019;s:114:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_to_controller_actions_through_using_the_fluent_api";d:0.018;s:80:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_with_middlewares";d:0.021;s:111:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_grouped_pipes_and_pass_all_key_to_the_contained_pipes";d:0.02;s:127:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_fallback_pipes_to_handle_any_request_which_could_not_be_matched_otherwise";d:0.019;s:74:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_match_dynamic_parameters";d:0.019;s:140:"Mshule\LaravelPipes\Tests\PipeRequestTest::its_dynamic_pattern_match_checks_first_for_placeholder_name_in_request_then_for_default_cue_value";d:0.014;s:83:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_match_multiple_dynamic_parameters";d:0.023;s:89:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_match_dynamic_parameters_to_any_request";d:0.02;s:84:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_conditions_to_pipe_definitions";d:0.029;s:70:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_aliases_to_pipes";d:0.018;s:81:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_aliases_predefined_to_pipes";d:0.019;s:78:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_bind_models_to_pipe_requests";d:0.029;s:71:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_load_pipes_from_files";d:0.019;s:84:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_ignores_global_helper_functions_as_cue";d:0.021;}}}
1+
C:37:"PHPUnit\Runner\DefaultTestResultCache":2453:{a:2:{s:7:"defects";a:0:{}s:5:"times";a:22:{s:106:"Mshule\LaravelPipes\Tests\PipeRequestTest::a_not_found_pipe_exception_is_thrown_if_no_controller_was_found";d:0.531;s:73:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_returns_a_ok_200er_response";d:0.052;s:100:"Mshule\LaravelPipes\Tests\PipeRequestTest::the_response_can_be_changed_through_the_response_resolver";d:0.021;s:122:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_fires_an_incoming_pipe_request_event_when_a_request_is_handled_by_the_kernel";d:0.021;s:125:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_fires_an_incoming_pipe_response_event_when_a_response_is_returned_by_the_kernel";d:0.019;s:76:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_to_callbacks";d:0.02;s:77:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_matches_everything_to_lowercase";d:0.018;s:85:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_to_controller_actions";d:0.027;s:114:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_to_controller_actions_through_using_the_fluent_api";d:0.019;s:80:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_with_middlewares";d:0.021;s:111:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_grouped_pipes_and_pass_all_key_to_the_contained_pipes";d:0.022;s:127:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_fallback_pipes_to_handle_any_request_which_could_not_be_matched_otherwise";d:0.021;s:74:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_match_dynamic_parameters";d:0.019;s:140:"Mshule\LaravelPipes\Tests\PipeRequestTest::its_dynamic_pattern_match_checks_first_for_placeholder_name_in_request_then_for_default_cue_value";d:0.023;s:83:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_match_multiple_dynamic_parameters";d:0.021;s:89:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_match_dynamic_parameters_to_any_request";d:0.019;s:84:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_conditions_to_pipe_definitions";d:0.031;s:70:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_aliases_to_pipes";d:0.017;s:81:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_aliases_predefined_to_pipes";d:0.02;s:78:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_bind_models_to_pipe_requests";d:0.032;s:71:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_load_pipes_from_files";d:0.025;s:84:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_ignores_global_helper_functions_as_cue";d:0.021;}}}

src/Response.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
namespace Mshule\LaravelPipes;
44

5-
use Illuminate\Http\Response as HttpResponse;
65
use Illuminate\Foundation\Testing\TestResponse;
76

87
class Response
@@ -11,9 +10,10 @@ class Response
1110
* Creates a test response if the app is in testing environment.
1211
*
1312
* @param HttpResponse $response
13+
*
1414
* @return \Illuminate\Http\Response|\Illuminate\Foundation\Testing\TestResponse
1515
*/
16-
public static function from(HttpResponse $response)
16+
public static function from($response)
1717
{
1818
return app()->environment('testing')
1919
? new TestResponse($response)

0 commit comments

Comments
 (0)