From 5c1863ac15d9f2971947202fbdffbe06b4dce1ce Mon Sep 17 00:00:00 2001
From: Franciszek S Wawrzak <frank@wawrzak.com>
Date: Tue, 29 Jul 2025 17:13:07 +0200
Subject: [PATCH] fix UPS rest api error handling

prevent $debugData['result'] to be set to empty string in case of api errors.
---
 app/code/Magento/Ups/Model/Carrier.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/code/Magento/Ups/Model/Carrier.php b/app/code/Magento/Ups/Model/Carrier.php
index 7130848406f29..e5f6784761da6 100644
--- a/app/code/Magento/Ups/Model/Carrier.php
+++ b/app/code/Magento/Ups/Model/Carrier.php
@@ -1200,10 +1200,10 @@ function () use ($httpResponse, $debugData) {
                             $debugData['result'] = ['error' => $e->getMessage(), 'code' => $e->getCode()];
                             $this->_logger->critical($e);
                         }
-                        if ($responseResult) {
-                            $jsonResponse = $responseResult->getStatusCode() >= 400 ? '' : $responseResult->getBody();
+                        if ($responseResult && ($responseResult->getStatusCode() < 400)) {
+                            $jsonResponse = $responseResult->getBody();
+                            $debugData['result'] = $jsonResponse;
                         }
-                        $debugData['result'] = $jsonResponse;
                         $this->_debug($debugData);
 
                         return $this->_parseRestResponse($jsonResponse);