Skip to content

Unsupported syntax for typescript version < 5.0.0 #7932

Open
@yishay-feldman-cyera

Description

@yishay-feldman-cyera

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

8.0.2

What package has an issue?

@mantine/core

What framework do you use?

Vite

In which browsers you can reproduce the issue?

All

Describe the bug

I'm using a project which has a typescript version of 4.9.5
While building the project I get some errors from:
@mantine/core/lib/components/Modal/use-modals-stack.d.ts
Specifically the issue is with this line:
export declare function useModalsStack<const T extends string>(modals: T[]): ModalStackReturnType<T>;

As it seems, this line uses some new typescript syntax that is only available from V5 and fails builds that are done in projects that use lower versions (for example 4.9.5)

If possible, include a link to a codesandbox with a minimal reproduction

No response

Possible fix

Is it possible to change this line to something that typescript < 5.0.0 still supports?

Self-service

  • I would be willing to implement a fix for this issue

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions