Skip to content

Library is breaking safari-features (e.g. web-push) #22

@HailToDodongo

Description

@HailToDodongo

In this line the variable safari is set, which will also override window.safari :

var safari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent),

However, this is already set by safari itself and contains important objects like window.safari.pushNotification.
This prevents/breaks web-push functionality on safari.
These checks should be scoped locally anyways to prevent polluting the global namespace.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions