Skip to content

integration_time plus **1** second (fixed) blocked reliable measures #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elemhsb opened this issue Mar 1, 2019 · 1 comment
Open

Comments

@elemhsb
Copy link

elemhsb commented Mar 1, 2019

time.sleep(0.120*self.integration_time+1) # not sure if we need it "// Wait x ms for ADC to complete"

Typo here: () missing
time.sleep(0.120self.integration_time+1) # takes minimal 1 second + 0.120self.integration_time

You want:
time.sleep(0.120*(self.integration_time+1))

Fastest working is:
time.sleep(0.105+0.100*self.integration)

@cmur2
Copy link

cmur2 commented Mar 1, 2019

Seconded! I use a local copy of this helpful repository and fixed it there but never reported here, sorry...

The initial clue for that comes form the official Adafruit driver and datasheet: https://github.com/adafruit/Adafruit_TSL2591_Library/blob/master/Adafruit_TSL2591.cpp#L316-L320 in combination with https://github.com/adafruit/Adafruit_TSL2591_Library/blob/master/Adafruit_TSL2591.h#L84

kyletaylored added a commit to kyletaylored/python-tsl2591 that referenced this issue May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants