Skip to content

Commit 09440ac

Browse files
committed
Remove redundant js actions logic
1 parent dcc8409 commit 09440ac

File tree

2 files changed

+4
-17
lines changed

2 files changed

+4
-17
lines changed

.github/workflows/NativePipeline.yml

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -211,25 +211,11 @@ jobs:
211211
[ "${{ github.event_name }}" = "schedule" ]; then
212212
widgets=$(echo '${{ needs.scope.outputs.widgets }}' | jq -r '.[]')
213213
for w in $widgets; do
214-
# Skip JS actions if already built above
215-
if [ "$w" != "mobile-resources-native" ] && [ "$w" != "nanoflow-actions-native" ]; then
216-
yarn workspace $w run build
217-
fi
214+
yarn workspace $w run build
218215
done
219216
fi
220217
- name: "Unit test"
221218
run: yarn workspaces foreach ${{ needs.scope.outputs.scope }} run test
222-
# - name: "Run build for development"
223-
# run: |
224-
# if [ "${{ github.event.inputs.workspace }}" = "js-actions" ] || \
225-
# [ "${{ github.event.inputs.workspace }}" = "*-native" ] || \
226-
# [ "${{ github.event_name }}" = "schedule" ]; then
227-
# yarn workspace mobile-resources-native run build
228-
# yarn workspace nanoflow-actions-native run build
229-
# fi
230-
# yarn workspaces foreach ${{ needs.scope.outputs.scope }} run build
231-
# env:
232-
# NODE_OPTIONS: --max_old_space_size=6144
233219
- name: "Upload JS actions resources artifact"
234220
if: ${{ github.event.inputs.workspace == 'js-actions' }}
235221
uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 #v4
@@ -238,7 +224,6 @@ jobs:
238224
path: |
239225
packages/jsActions/mobile-resources-native/dist/**/*
240226
packages/jsActions/nanoflow-actions-native/dist/**/*
241-
242227
- name: "Upload widget and JS actions resources artifact"
243228
if: ${{ github.event.inputs.workspace != 'js-actions' }}
244229
uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 #v4

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,9 @@
3333
"patch-package": "sh ./scripts/patch/patch-package.sh",
3434
"build:widgets": "node ./scripts/widget/buildWidgets.js",
3535
"test_widgets:maestro:ios": "bash maestro/run_maestro_widget_tests.sh ios",
36-
"test_widgets:maestro:android": "bash maestro/run_maestro_widget_tests.sh android"
36+
"test_widgets:maestro:android": "bash maestro/run_maestro_widget_tests.sh android",
37+
"test_jsactions:maestro:ios": "bash maestro/run_maestro_jsactions_tests.sh ios",
38+
"test_jsactions:maestro:android": "bash maestro/run_maestro_jsactions_tests.sh android"
3739
},
3840
"workspaces": {
3941
"packages": [

0 commit comments

Comments
 (0)