Skip to content

Commit 5c9e265

Browse files
committed
fix(rating-native): make the widget compatible with rn 0.73.8
1 parent 768a876 commit 5c9e265

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

packages/pluggableWidgets/rating-native/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## [Unreleased]
88

9+
### BREAKING
10+
11+
- We made the widget compatible with React Native 0.73.8
12+
913
## [4.0.0] - 2023-01-24
1014

1115
## BREAKING

packages/pluggableWidgets/rating-native/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "rating-native",
33
"widgetName": "Rating",
4-
"version": "4.0.0",
4+
"version": "5.0.0",
55
"license": "Apache-2.0",
66
"repository": {
77
"type": "git",

packages/pluggableWidgets/rating-native/src/lib/StarRating.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// has an outdated dependency (react-native-vector-icons) that we now managed here in this widget.
33
import { ClassicComponentClass, Component, createElement } from "react";
44
import { View, StyleSheet, ViewStyle } from "react-native";
5-
import { AnimatableProperties, View as AnimatableView } from "react-native-animatable";
5+
import { AnimatableProps, View as AnimatableView } from "react-native-animatable";
66
import type { StarRatingProps } from "react-native-star-rating";
77

88
import StarButton, { iconSets } from "./StarButton";
@@ -67,7 +67,7 @@ interface AnimationProps {
6767

6868
class StarRating extends Component<Props> {
6969
static defaultProps: typeof defaultProps;
70-
starRef: Array<ClassicComponentClass<AnimatableProperties<ViewStyle>> & AnimationProps>;
70+
starRef: Array<ClassicComponentClass<AnimatableProps<ViewStyle>> & AnimationProps>;
7171

7272
constructor(props: Props) {
7373
super(props);
@@ -128,9 +128,7 @@ class StarRating extends Component<Props> {
128128
key={i}
129129
ref={node => {
130130
if (node) {
131-
this.starRef[i] = node as unknown as ClassicComponentClass<
132-
AnimatableProperties<ViewStyle>
133-
> &
131+
this.starRef[i] = node as unknown as ClassicComponentClass<AnimatableProps<ViewStyle>> &
134132
AnimationProps;
135133
}
136134
}}

packages/pluggableWidgets/rating-native/src/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8" ?>
22
<package xmlns="http://www.mendix.com/package/1.0/">
3-
<clientModule name="Rating" version="4.0.0" xmlns="http://www.mendix.com/clientModule/1.0/">
3+
<clientModule name="Rating" version="5.0.0" xmlns="http://www.mendix.com/clientModule/1.0/">
44
<widgetFiles>
55
<widgetFile path="Rating.xml" />
66
</widgetFiles>

0 commit comments

Comments
 (0)