Skip to content

Commit 9c7e7e9

Browse files
committed
fix: do not blindly fallback to text viewer
1 parent 51b63f3 commit 9c7e7e9

File tree

2 files changed

+17
-4
lines changed

2 files changed

+17
-4
lines changed

packages/pluggableWidgets/document-viewer-web/components/TextViewer.tsx

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,21 @@ const TextViewer: DocRendererElement = (props: DocumentRendererProps) => {
3434

3535
TextViewer.contentTypes = ["text/plain", "text/csv", "application/json"];
3636

37-
TextViewer.fileTypes = ["txt", "csv", "json"];
37+
TextViewer.fileTypes = [
38+
"txt",
39+
"csv",
40+
"json",
41+
"text",
42+
"log",
43+
"xml",
44+
"html",
45+
"htm",
46+
"css",
47+
"js",
48+
"jsx",
49+
"ts",
50+
"tsx",
51+
"svg"
52+
];
3853

3954
export default TextViewer;

packages/pluggableWidgets/document-viewer-web/utils/useRendererSelector.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ import { DocumentRenderers } from "../components";
44
import { DocRendererElement, DocumentRendererProps, DocumentStatus } from "../components/documentRenderer";
55
import ErrorViewer from "../components/ErrorViewer";
66
import { DocumentViewerContainerProps } from "../typings/DocumentViewerProps";
7-
import TextViewer from "../components/TextViewer";
8-
97
interface DocumentRenderer {
108
CurrentRenderer: DocRendererElement;
119
props: DocumentRendererProps;
@@ -46,7 +44,7 @@ export function useRendererSelector(props: DocumentViewerContainerProps): Docume
4644
if (selectedRenderer.length > 0) {
4745
setComponent(() => selectedRenderer[0]);
4846
} else {
49-
setComponent(() => TextViewer);
47+
setDocumentStatus(DocumentStatus.error);
5048
}
5149
}
5250
});

0 commit comments

Comments
 (0)