Skip to content

Commit 4e06de7

Browse files
committed
feat: ⚡ cleanup and A11y on List
1 parent 4e83b63 commit 4e06de7

File tree

3 files changed

+5
-20
lines changed

3 files changed

+5
-20
lines changed

packages/web-widgets/drag-and-drop-widget/src/Draganddropwidget.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,9 @@ export default class Draganddropwidget extends Component<DraganddropwidgetContai
115115
};
116116

117117
render(): ReactNode {
118+
console.log(`this.props`, this.props);
118119
const { listOfSortableItems } = this.state;
119120
const { content, emptyData } = this.props;
120-
console.log(`this.props`, this.props);
121121
if (listOfSortableItems) {
122122
if (isTouchDevice()) {
123123
return (

packages/web-widgets/drag-and-drop-widget/src/components/DragCard.tsx

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,14 @@
11
import { createElement, useRef, ReactElement } from "react";
22
import { useDrag, useDrop, DragObjectWithType, DragSourceMonitor } from "react-dnd";
3-
import { useDragDropManager } from "react-dnd";
43

54
import classnames from "classnames";
65
import { DragCardType, ListOfSortableItemsType } from "./types";
76

87
const DragCard = ({ children, item, index, reorderAfterDrop, listOfSortableItems }: DragCardType): ReactElement => {
9-
const t = useDragDropManager();
10-
console.log(`useDragDropManager()`, t.getActions());
118
const ref = useRef<HTMLDivElement>(null);
129

1310
const findOrder = (hoverItem: any, monitor: DragSourceMonitor): number => {
11+
console.log(`isOver`, monitor.getItem());
1412
const hoverIndex = index;
1513
const dragIndex = hoverItem.index;
1614

@@ -79,24 +77,11 @@ const DragCard = ({ children, item, index, reorderAfterDrop, listOfSortableItems
7977
"drag-and-drop__is-over": isOver,
8078
"drag-and-drop__is-dragging": isDragging
8179
});
82-
const u = t.getMonitor();
8380
return (
8481
<div
85-
onKeyPress={event => {
86-
if (event.key === "Enter") {
87-
console.log("1");
88-
89-
const y = t.getMonitor().getSourceId();
90-
console.log(`y`, y);
91-
if (y) {
92-
console.log("2");
93-
console.log("enter press here! ", t.getActions().beginDrag([y]));
94-
console.log("enter press here! ", t.getActions().hover([y]));
95-
}
96-
}
97-
}}
98-
className={customClassNames}
82+
role="listitem"
9983
tabIndex={0}
84+
className={customClassNames}
10085
// Used For Testing Only
10186
style={{
10287
padding: "0.5rem 1rem",

packages/web-widgets/drag-and-drop-widget/src/components/DragInit.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { DragListProps, ListOfSortableItemsType } from "./types";
44

55
function Column({ listOfSortableItems, content, reorderAfterDrop, emptyData }: DragListProps): ReactElement {
66
return (
7-
<div className="app">
7+
<div role="list" className="drag-and-drop__list">
88
{listOfSortableItems.length ? (
99
listOfSortableItems.map((fullItem: ListOfSortableItemsType, index: number) => {
1010
return (

0 commit comments

Comments
 (0)