Forward builtin options to subprojects #14498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzini
force-pushed
the
fix14497
branch
3 times, most recently
from
fdf860d to
69249c9
Compare
|
|
dcbaker
requested changes
Apr 21, 2025
bonzini
force-pushed
the
fix14497
branch
2 times, most recently
from
3d0658f to
e437547
Compare
Added a unit test (and verified that it fails without the changes). |
Prepare for adding more complex logic to add_system_option_internal, in order to handle inheritance of global options to subprojects. Do the same in add_project_option to make the similarities and differences evident. Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Because system options apply to all subprojects, they need to be present globally whenever a subproject needs them. Signed-off-by: Paolo Bonzini <[email protected]>
The data is already available in the OptionStore's pending_options and add_compiler_option() will pick it from there. Signed-off-by: Paolo Bonzini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several issues here:
Some of these issues were masked by usage of env.options, which should not be needed anymore after the option refactoring; all the required information is stored in OptionStore's pending_options after the
project()call.Let's see how much this breaks.Fixes: #14497