fix(selectorBase): do not validate components with directives rule

Author: mgechev

src/componentSelectorRule.ts

@@ -1,8 +1,9 @@
 import {SelectorRule} from './selectorNameBase';
 
 export class Rule extends SelectorRule {
-    public getTypeFailure():any { return 'The selector of the component "%s" should be used as %s ($$05-03$$)'; }
-    public getNameFailure():any { return 'The selector of the component "%s" should be named %s ($$05-02$$)'; }
-    getSinglePrefixFailure():any { return 'The selector of the component "%s" should have prefix "%s" ($$02-07$$)'; }
-    getManyPrefixFailure():any { return 'The selector of the component "%s" should have one of the prefixes: %s ($$02-07$$)'; }
+  public handleType = 'Component';
+  public getTypeFailure():any { return 'The selector of the component "%s" should be used as %s ($$05-03$$)'; }
+  public getNameFailure():any { return 'The selector of the component "%s" should be named %s ($$05-02$$)'; }
+  getSinglePrefixFailure():any { return 'The selector of the component "%s" should have prefix "%s" ($$02-07$$)'; }
+  getManyPrefixFailure():any { return 'The selector of the component "%s" should have one of the prefixes: %s ($$02-07$$)'; }
 }

src/directiveSelectorRule.ts

@@ -1,9 +1,10 @@
 import {SelectorRule} from './selectorNameBase';
 
 export class Rule extends SelectorRule {
-    public getTypeFailure():any { return 'The selector of the directive "%s" should be used as %s ($$02-06$$)'; }
-    public getNameFailure():any { return 'The selector of the directive "%s" should be named %s ($$02-06$$)'; }
-    getSinglePrefixFailure():any { return 'The selector of the directive "%s" should have prefix "%s" ($$02-08$$)'; }
-    getManyPrefixFailure():any { return 'The selector of the directive "%s" should have one of the prefixes: %s ($$02-08$$)'; }
+  public handleType = 'Directive';
+  public getTypeFailure():any { return 'The selector of the directive "%s" should be used as %s ($$02-06$$)'; }
+  public getNameFailure():any { return 'The selector of the directive "%s" should be named %s ($$02-06$$)'; }
+  getSinglePrefixFailure():any { return 'The selector of the directive "%s" should have prefix "%s" ($$02-08$$)'; }
+  getManyPrefixFailure():any { return 'The selector of the directive "%s" should have one of the prefixes: %s ($$02-08$$)'; }
 }
 

src/selectorNameBase.ts

@@ -11,6 +11,8 @@ export abstract class SelectorRule extends Lint.Rules.AbstractRule {
   public prefixArguments:string;
   public cssSelectorProperty:string;
 
+  public handleType: string;
+
   private typeValidator:Function;
   private prefixValidator:Function;
   private nameValidator:Function;
@@ -126,7 +128,8 @@ export class SelectorValidatorWalker extends Lint.RuleWalker {
     let name = expr.text;
     let args = baseExpr.arguments || [];
     let arg = args[0];
-    if (name === 'Component' || name === 'Directive') {
+    // Do not run component rules for directives
+    if (this.rule.handleType === name) {
       this.validateSelector(className, arg);
     }
   }

test/directiveSelectorRule.spec.ts

@@ -214,6 +214,14 @@ describe('directive-selector-type', () => {
       @Directive({
         selector: '[sgBarFoo]'
       })
+      class Test {}`;
+            assertSuccess('directive-selector', source, ['attribute','sg','camelCase']);
+        });
+        it('should not validate @Component', () => {
+            let source = `
+      @Component({
+        selector: 'sg-bar-foo'
+      })
       class Test {}`;
             assertSuccess('directive-selector', source, ['attribute','sg','camelCase']);
         });