Skip to content

Support a wider range of termination conditions in AGS #6163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #4006
victordibia opened this issue Apr 1, 2025 · 0 comments · May be fixed by #6273
Open
Tracked by #4006

Support a wider range of termination conditions in AGS #6163

victordibia opened this issue Apr 1, 2025 · 0 comments · May be fixed by #6273
Labels
proj-studio

Comments

@victordibia
Copy link
Collaborator

victordibia commented Apr 1, 2025 •
edited
Loading

AGS UI currently supports text message term and max message term.
In reality, AgentChat supports much more.
This PR is to track work on ensuring parity across agentchat and ags UI

cc @ekzhu
@victordibia victordibia mentioned this issue Apr 1, 2025
Open
60 tasks
ShyamSathish005 added a commit to ShyamSathish005/autogen that referenced this issue Apr 11, 2025
@ShyamSathish005
Support a wider range of termination conditions in AGS
2766b47 
Fixes microsoft#6163

Added support for a broader range of termination conditions in AGS UI to ensure parity with AgentChat

* **Abstractions/Termination.cs**: Add new termination conditions `FunctionCallTermination`, `HandoffTermination`, `TokenUsageTermination`, `SourceMatchTermination`, `TextMentionTermination`, and `StopMessageTermination` to the `ITerminationCondition` interface. Update the `CombinerCondition` class to support the new termination conditions.
* **Terminations/ExternalTermination.cs**: Update the `ExternalTermination` class to support the new termination conditions.
* **Terminations/FunctionCallTermination.cs**: Update the `FunctionCallTermination` class to support the new termination conditions.
* **Terminations/HandoffTermination.cs**: Update the `HandoffTermination` class to support the new termination conditions.
* **Terminations/TokenUsageTermination.cs**: Update the `TokenUsageTermination` class to support the new termination conditions.
* **Terminations/SourceMatchTermination.cs**: Update the `SourceMatchTermination` class to support the new termination conditions.
* **Terminations/TextMentionTermination.cs**: Update the `TextMentionTermination` class to support the new termination conditions.
* **Terminations/StopMessageTermination.cs**: Update the `StopMessageTermination` class to support the new termination conditions.
* **Tests/TerminationConditionTests.cs**: Add unit tests for the new termination conditions in the `TerminationConditionTests` class.
@ShyamSathish005 ShyamSathish005 linked a pull request Apr 11, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proj-studio
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support a wider range of termination conditions in AGS ShyamSathish005/autogen
1 participant
@victordibia