Enable deploying Azure Storage account File shares with user specified storage quota. (#3611)

* update azure file share function to accept quota

* fix for incorrect documentation stating value in bytes

* Update common.py

* change quota to quota_in_gb for better readibility

* missing comma,BLK100

Author: shekharsorot

lisa/sut_orchestrator/azure/common.py

@@ -1975,6 +1975,8 @@ def get_share_service_client(
     return share_service_client
 
 
+# Update: Added quota to allow creation of variable sized file share volumes.
+# Default is 100 GiB. All units are in GiB.
 def get_or_create_file_share(
     credential: Any,
     subscription_id: str,
@@ -1984,9 +1986,10 @@ def get_or_create_file_share(
     resource_group_name: str,
     log: Logger,
     protocols: str = "SMB",
+    quota_in_gb: int = 100,
 ) -> str:
     """
-    Create a Azure Storage file share if it does not exist.
+    Create an Azure Storage file share if it does not exist.
     """
     share_service_client = get_share_service_client(
         credential,
@@ -1998,7 +2001,11 @@ def get_or_create_file_share(
     all_shares = list(share_service_client.list_shares())
     if file_share_name not in (x.name for x in all_shares):
         log.debug(f"creating file share {file_share_name} with protocols {protocols}")
-        share_service_client.create_share(file_share_name, protocols=protocols)
+        share_service_client.create_share(
+            file_share_name,
+            protocols=protocols,
+            quota=quota_in_gb,
+        )
     return str("//" + share_service_client.primary_hostname + "/" + file_share_name)
 
 

lisa/sut_orchestrator/azure/features.py

@@ -2916,7 +2916,10 @@ def _initialize(self, *args: Any, **kwargs: Any) -> None:
         self.storage_account_name: str = ""
         self.file_share_name: str = ""
 
-    def create_share(self) -> None:
+    def create_share(
+        self,
+        quota_in_gb: int = 100,
+    ) -> None:
         platform: AzurePlatform = self._platform  # type: ignore
         node_context = self._node.capability.get_extended_runbook(AzureNodeSchema)
         location = node_context.location
@@ -2947,6 +2950,7 @@ def create_share(self) -> None:
             resource_group_name=resource_group_name,
             protocols="NFS",
             log=self._log,
+            quota_in_gb=quota_in_gb,
         )
 
         storage_account_resource_id = (
@@ -3480,6 +3484,7 @@ def create_file_share(
         kind: str = "StorageV2",
         enable_https_traffic_only: bool = True,
         enable_private_endpoint: bool = False,
+        quota_in_gb: int = 100,
     ) -> Dict[str, str]:
         platform: AzurePlatform = self._platform  # type: ignore
         information = environment.get_information()
@@ -3505,6 +3510,8 @@ def create_file_share(
         # If enable_private_endpoint is true, SMB share endpoint
         # will dns resolve to <share>.privatelink.file.core.windows.net
         # No changes need to be done in code calling function
+        # For Quota, currently all volumes will share same quota number.
+        # Ensure that you use the highest value applicable for your shares
         for share_name in file_share_names:
             fs_url_dict[share_name] = get_or_create_file_share(
                 credential=platform.credential,
@@ -3514,6 +3521,7 @@ def create_file_share(
                 file_share_name=share_name,
                 resource_group_name=resource_group_name,
                 log=self._log,
+                quota_in_gb=quota_in_gb,
             )
         # Create file private endpoint, always after all shares have been created
         # There is a known issue in API preventing access to data plane