MONGOCRYPT-768 remove possible double-free (#967)

kevinAlbs · web-flow · commit 9378602db9d5 · 2025-02-27T10:17:40.000-05:00
diff --git a/src/mc-schema-broker.c b/src/mc-schema-broker.c
@@ -474,8 +474,6 @@ bool mc_schema_broker_satisfy_from_cache(mc_schema_broker_t *sb,
         }
 
         if (!mc_schema_entry_satisfy_from_collinfo(it, collinfo, sb->db, it->coll, sb->use_range_v2, status)) {
-            bson_destroy(collinfo);
-            bson_free(ns);
             goto loop_fail;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -474,8 +474,6 @@ bool mc_schema_broker_satisfy_from_cache(mc_schema_broker_t *sb,`
`474`	`474`	`}`
`475`	`475`
`476`	`476`	`if (!mc_schema_entry_satisfy_from_collinfo(it, collinfo, sb->db, it->coll, sb->use_range_v2, status)) {`
`477`		`- bson_destroy(collinfo);`
`478`		`- bson_free(ns);`
`479`	`477`	`goto loop_fail;`
`480`	`478`	`}`
`481`	`479`