Skip to content

Commit 09fd306

Browse files
fix wrong response data
1 parent eb64f55 commit 09fd306

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

cmd/server/files.go

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,12 @@ func deleteFile(logger log.Logger, repo WireFileRepository) http.HandlerFunc {
201201

202202
w.Header().Set("Content-Type", "application/json; charset=utf-8")
203203
w.WriteHeader(http.StatusOK)
204-
json.NewEncoder(w).Encode(`{"error": null}`)
204+
205+
type response struct {
206+
Error error `json:"error"`
207+
}
208+
209+
json.NewEncoder(w).Encode(&response{Error: nil})
205210
}
206211
}
207212

@@ -287,7 +292,12 @@ func validateFile(logger log.Logger, repo WireFileRepository) http.HandlerFunc {
287292
logger.Log("validated file")
288293
w.Header().Set("Content-Type", "application/json; charset=utf-8")
289294
w.WriteHeader(http.StatusOK)
290-
json.NewEncoder(w).Encode(`{"error": null}`)
295+
296+
type response struct {
297+
Error error `json:"error"`
298+
}
299+
300+
json.NewEncoder(w).Encode(&response{Error: nil})
291301
}
292302
}
293303

cmd/server/files_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,7 @@ func TestFiles_deleteFile(t *testing.T) {
264264
w.Flush()
265265

266266
assert.Equal(t, http.StatusOK, w.Code, w.Body)
267+
assert.Contains(t, w.Body.String(), `{"error":null}`)
267268
})
268269

269270
t.Run("repo error", func(t *testing.T) {
@@ -411,8 +412,7 @@ func TestFiles_validateFile(t *testing.T) {
411412
router.ServeHTTP(w, req)
412413
w.Flush()
413414

414-
assert.Equal(t, http.StatusOK, w.Code, w.Body)
415-
assert.Contains(t, w.Body.String(), `"{\"error\": null}"`)
415+
assert.Contains(t, w.Body.String(), `{"error":null}`)
416416
})
417417

418418
t.Run("repo error", func(t *testing.T) {

0 commit comments

Comments
 (0)