the character [ is typed twice in the object inspector

[fochen79]

Hi
in the object inspector write [ in the caption field and press enter then it will shows [[

[fredvs]

Hello.

Hum, indeed, just tested and one "[" gives "[[".

I never noted it so thanks to signal it.
I will jump into this asap (lot of work now, sorry).

Of course if you have seen something that could help to debug it, please say it.

[rchastain]

Hello MSEgui friends.

Good news for you Fred: You didn't introduced that bug. It's already in MSEide 4.6.2. :)

[fredvs]

Ha, ok, thanks Roland.
I am inside Object Inspector but dont see where to jump.

I did try this:

procedure tobjectinspectorfo.valueupdaterowvalue(const sender: tobject;
  const aindex: integer; const aitem: tlistitem);
var
str : string;  
begin
 if (aitem <> nil) and (tpropertyvalue(aitem).feditor <> nil) then begin
  with tpropertyvalue(aitem).feditor do begin
   if (aindex = values.activerow) or allequal then begin
    str := removelinebreaks(getvalue);
    aitem.caption:= stringreplace(str, '[[', '[', [rfReplaceAll]); // here
   end
   else begin
    aitem.caption:= '';
   end;
   end;
 end;
end; 

After Enter, the '[[' does not appear, only '['.
But if you reselect the caption, the '[[' reappears. ;-(

[rchastain]

That code seems to me to be a kind of pansement sur une jambe de bois. :)

There is no emergency. Let's take time to understand what happens. I will take a look.

[fredvs]

Yes, of course, I am exploring, imho there is something wrong in getvalue from mclasses.pas.
OK, je te passe le relais.

[rchastain]

It looks like the problem is in lib/common/designutils/msepropertyeditors.pas:

const
 { ... }
 numcharchar = msechar('[');

But I still have to understand the purpose of that constant.

[rchastain]

I tried to redefine the constant as follows:

const
 { ... }
 numcharchar = msechar('$');

As expected, it solves the issue of the '[' but creates another issue with '$'.

What to do? It's up to you, Fred. My opinion would be to let the code as it is.

[fredvs]

Hello Roland.

numcharchar = msechar('[');

Ho, well seen.
Hum, I did try yesterday with Find in file, ---> '[' and it did not show your discovery, you are a better explorer than me.

What to do? It's up to you, Fred. My opinion would be to let the code as it is.

Ok, I will jump into it (asap), write you later.

[fredvs]

A way to fix the problem is commenting numcharchar here :

function tpropertyeditor.decodemsestring(const avalue: msestring): msestring;
...
 case avalue[int1] of
    c_tab: begin po1^:= numcharchar; inc(po1); po1^:= 't'; end;
    c_linefeed: begin po1^:= numcharchar; inc(po1); po1^:= 'n'; end;
    c_return: begin po1^:= numcharchar; inc(po1); po1^:= 'r'; end;
    c_softhyphen: begin po1^:= numcharchar; inc(po1); po1^:= 's'; end;
    // numcharchar: begin po1^:= numcharchar; inc(po1); po1^:= numcharchar; end; // comment this
   else begin
         // and this will be used for '['

It fixes the problem but maybe it creates a other (at first tests no, but I did not test deeply) ...

[fredvs]

Tested with ideU deeply and I did not find problems yet, '[' is entered only once and all properties using '[' seems ok.

Did try loading other projects and object inspector seems happy too + compilation.

[fredvs]

After deep test I did not find problem with the patch.
But maybe I have missed something.

@fochen79: Here the patched msepropertyeditors.pas if you need '[' in the caption of one component.
Copy the unzipped file in /mseide-msegui/lib/common/designutils/
And recompile /mseide-msegui/apps/ide/mseide.prj.

msepropertyeditors.zip

Personally, even if I did not find problems, I am a few afraid to commit it in official msegui.

[fochen79]

Hi Fred , thanks for the fix
i tried it and it seems ok , no double [ anymore

btw
i didn't understand the purpose of this line ( numcharchar: begin po1^:= numcharchar; inc(po1); po1^:= numcharchar; end; )

[fredvs]

i didn't understand the purpose of this line ( numcharchar: begin po1^:= numcharchar; inc(po1); po1^:= numcharchar; end;

Same for me.