Improved checks for vehicle in & out packet (#4112)

Nico8340 · web-flow · commit 372b1e5910c4 · 2025-03-17T23:31:26.000Z
diff --git a/Server/mods/deathmatch/logic/CGame.cpp b/Server/mods/deathmatch/logic/CGame.cpp
@@ -2973,7 +2973,7 @@ void CGame::Packet_Vehicle_InOut(CVehicleInOutPacket& Packet)
             // Grab the ped with the chosen ID
             ElementID PedID = Packet.GetPedID();
             CElement* pPedElement = CElementIDs::GetElement(PedID);
-            if (pPedElement && IS_PED(pPedElement))
+            if (pPedElement && IS_PED(pPedElement) && (pPedElement == pPlayer || !IS_PLAYER(pPedElement)))
             {
                 CPed*     pPed = static_cast<CPed*>(pPedElement);
                 bool      bValidPed = false;

Original file line number	Diff line number	Diff line change
`@@ -2973,7 +2973,7 @@ void CGame::Packet_Vehicle_InOut(CVehicleInOutPacket& Packet)`
`2973`	`2973`	`// Grab the ped with the chosen ID`
`2974`	`2974`	`ElementID PedID = Packet.GetPedID();`
`2975`	`2975`	`CElement* pPedElement = CElementIDs::GetElement(PedID);`
`2976`		`- if (pPedElement && IS_PED(pPedElement))`
	`2976`	`+ if (pPedElement && IS_PED(pPedElement) && (pPedElement == pPlayer \|\| !IS_PLAYER(pPedElement)))`
`2977`	`2977`	`{`
`2978`	`2978`	`CPed* pPed = static_cast<CPed*>(pPedElement);`
`2979`	`2979`	`bool bValidPed = false;`