Refactor benchmarks and improve code clarity

- Updated `LibraryComparisonBenchmarks.cs` to use a record type for `TestData`, enhancing readability and modernizing the code structure.
- Added summary comments in `HttpUserAgentParserMemoryCacheServiceCollectionExtensions.cs` and improved method documentation for clarity.
- Streamlined constructor initialization in `HttpUserAgentParserMemoryCachedProviderOptions.cs`, removing unnecessary keywords while preserving functionality.

Author: BenjaminAbt

perf/HttpUserAgentParser.Benchmarks/LibraryComparison/LibraryComparisonBenchmarks.cs

@@ -7,80 +7,79 @@
 using DeviceDetectorNET;
 using MyCSharp.HttpUserAgentParser.Providers;
 
-namespace MyCSharp.HttpUserAgentParser.Benchmarks.LibraryComparison
+namespace MyCSharp.HttpUserAgentParser.Benchmarks.LibraryComparison;
+
+[ShortRunJob]
+[MemoryDiagnoser]
+[CategoriesColumn]
+[GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
+public class LibraryComparisonBenchmarks
 {
-    [ShortRunJob]
-    [MemoryDiagnoser]
-    [CategoriesColumn]
-    [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
-    public class LibraryComparisonBenchmarks
+    public record TestData(string Label, string UserAgent)
     {
-        public record TestData(string Label, string UserAgent)
-        {
-            public override string ToString() => Label;
-        }
+        public override string ToString() => Label;
+    }
 
-        [ParamsSource(nameof(GetTestUserAgents))]
-        public TestData Data { get; set; }
+    [ParamsSource(nameof(GetTestUserAgents))]
+    public TestData Data { get; set; }
 
-        public IEnumerable<TestData> GetTestUserAgents()
-        {
-            yield return new("Chrome Win10", "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.212 Safari/537.36");
-            yield return new("Google-Bot", "APIs-Google (+https://developers.google.com/webmasters/APIs-Google.html)");
-        }
+    public IEnumerable<TestData> GetTestUserAgents()
+    {
+        yield return new("Chrome Win10", "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.212 Safari/537.36");
+        yield return new("Google-Bot", "APIs-Google (+https://developers.google.com/webmasters/APIs-Google.html)");
+    }
 
-        [Benchmark(Baseline = true, Description = "MyCSharp")]
-        [BenchmarkCategory("Basic")]
-        public HttpUserAgentInformation MyCSharpBasic()
-        {
-            HttpUserAgentInformation info = HttpUserAgentParser.Parse(Data.UserAgent);
-            return info;
-        }
+    [Benchmark(Baseline = true, Description = "MyCSharp")]
+    [BenchmarkCategory("Basic")]
+    public HttpUserAgentInformation MyCSharpBasic()
+    {
+        HttpUserAgentInformation info = HttpUserAgentParser.Parse(Data.UserAgent);
+        return info;
+    }
 
-        private static readonly HttpUserAgentParserCachedProvider s_myCSharpCachedProvider = new();
+    private static readonly HttpUserAgentParserCachedProvider s_myCSharpCachedProvider = new();
 
-        [Benchmark(Baseline = true, Description = "MyCSharp")]
-        [BenchmarkCategory("Cached")]
-        public HttpUserAgentInformation MyCSharpCached()
-        {
-            return s_myCSharpCachedProvider.Parse(Data.UserAgent);
-        }
+    [Benchmark(Baseline = true, Description = "MyCSharp")]
+    [BenchmarkCategory("Cached")]
+    public HttpUserAgentInformation MyCSharpCached()
+    {
+        return s_myCSharpCachedProvider.Parse(Data.UserAgent);
+    }
 
-        [Benchmark(Description = "UAParser")]
-        [BenchmarkCategory("Basic")]
-        public UAParser.ClientInfo UAParserBasic()
-        {
-            UAParser.ClientInfo info = UAParser.Parser.GetDefault().Parse(Data.UserAgent);
-            return info;
-        }
+    [Benchmark(Description = "UAParser")]
+    [BenchmarkCategory("Basic")]
+    public UAParser.ClientInfo UAParserBasic()
+    {
+        UAParser.ClientInfo info = UAParser.Parser.GetDefault().Parse(Data.UserAgent);
+        return info;
+    }
 
-        private static readonly UAParser.Parser s_uaParser = UAParser.Parser.GetDefault(new UAParser.ParserOptions { UseCompiledRegex = true });
+    private static readonly UAParser.Parser s_uaParser = UAParser.Parser.GetDefault(new UAParser.ParserOptions { UseCompiledRegex = true });
 
-        [Benchmark(Description = "UAParser")]
-        [BenchmarkCategory("Cached")]
-        public UAParser.ClientInfo UAParserCached()
-        {
-            UAParser.ClientInfo info = s_uaParser.Parse(Data.UserAgent);
-            return info;
-        }
+    [Benchmark(Description = "UAParser")]
+    [BenchmarkCategory("Cached")]
+    public UAParser.ClientInfo UAParserCached()
+    {
+        UAParser.ClientInfo info = s_uaParser.Parse(Data.UserAgent);
+        return info;
+    }
 
-        [Benchmark(Description = "DeviceDetector.NET")]
-        [BenchmarkCategory("Basic")]
-        public object DeviceDetectorNETBasic()
-        {
-            DeviceDetector dd = new(Data.UserAgent);
-            dd.Parse();
+    [Benchmark(Description = "DeviceDetector.NET")]
+    [BenchmarkCategory("Basic")]
+    public object DeviceDetectorNETBasic()
+    {
+        DeviceDetector dd = new(Data.UserAgent);
+        dd.Parse();
 
-            var info = new
-            {
-                Client = dd.GetClient(),
-                OS = dd.GetOs(),
-                Device = dd.GetDeviceName(),
-                Brand = dd.GetBrandName(),
-                Model = dd.GetModel()
-            };
+        var info = new
+        {
+            Client = dd.GetClient(),
+            OS = dd.GetOs(),
+            Device = dd.GetDeviceName(),
+            Brand = dd.GetBrandName(),
+            Model = dd.GetModel()
+        };
 
-            return info;
-        }
+        return info;
     }
 }

src/HttpUserAgentParser.MemoryCache/DependencyInjection/HttpUserAgentParserMemoryCacheServiceCollectionExtensions.cs

@@ -4,27 +4,26 @@
 using MyCSharp.HttpUserAgentParser.DependencyInjection;
 using MyCSharp.HttpUserAgentParser.Providers;
 
-namespace MyCSharp.HttpUserAgentParser.MemoryCache.DependencyInjection
+namespace MyCSharp.HttpUserAgentParser.MemoryCache.DependencyInjection;
+
+/// <summary>
+/// Dependency injection extensions for IMemoryCache
+/// </summary>
+public static class HttpUserAgentParserMemoryCacheServiceCollectionExtensions
 {
     /// <summary>
-    /// Dependency injection extensions for IMemoryCache
+    /// Registers <see cref="HttpUserAgentParserCachedProvider"/> as singleton to <see cref="IHttpUserAgentParserProvider"/>
     /// </summary>
-    public static class HttpUserAgentParserMemoryCacheServiceCollectionExtensions
+    public static HttpUserAgentParserDependencyInjectionOptions AddHttpUserAgentMemoryCachedParser(
+        this IServiceCollection services, Action<HttpUserAgentParserMemoryCachedProviderOptions>? options = null)
     {
-        /// <summary>
-        /// Registers <see cref="HttpUserAgentParserCachedProvider"/> as singleton to <see cref="IHttpUserAgentParserProvider"/>
-        /// </summary>
-        public static HttpUserAgentParserDependencyInjectionOptions AddHttpUserAgentMemoryCachedParser(
-            this IServiceCollection services, Action<HttpUserAgentParserMemoryCachedProviderOptions>? options = null)
-        {
-            HttpUserAgentParserMemoryCachedProviderOptions providerOptions = new();
-            options?.Invoke(providerOptions);
+        HttpUserAgentParserMemoryCachedProviderOptions providerOptions = new();
+        options?.Invoke(providerOptions);
 
-            // register options
-            services.AddSingleton(providerOptions);
+        // register options
+        services.AddSingleton(providerOptions);
 
-            // register cache provider
-            return services.AddHttpUserAgentParser<HttpUserAgentParserMemoryCachedProvider>();
-        }
+        // register cache provider
+        return services.AddHttpUserAgentParser<HttpUserAgentParserMemoryCachedProvider>();
     }
 }

src/HttpUserAgentParser.MemoryCache/HttpUserAgentParserMemoryCachedProviderOptions.cs

@@ -41,13 +41,13 @@ public HttpUserAgentParserMemoryCachedProviderOptions(MemoryCacheEntryOptions ca
     public HttpUserAgentParserMemoryCachedProviderOptions(
         MemoryCacheOptions? cacheOptions = null, MemoryCacheEntryOptions? cacheEntryOptions = null)
     {
-        this.CacheEntryOptions = cacheEntryOptions ?? new MemoryCacheEntryOptions
+        CacheEntryOptions = cacheEntryOptions ?? new MemoryCacheEntryOptions
         {
             // defaults
             SlidingExpiration = TimeSpan.FromDays(1)
         };
 
-        this.CacheOptions = cacheOptions ?? new MemoryCacheOptions
+        CacheOptions = cacheOptions ?? new MemoryCacheOptions
         {
             // defaults
             SizeLimit = 256