Skip to content

Commit 0500634

Browse files
Refactor gallery picker code
1 parent 4c1afce commit 0500634

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

app/src/main/kotlin/run/nabla/gallerypicker/example/Navigation.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package run.nabla.gallerypicker.example
22

33
import android.net.Uri
4+
import androidx.compose.foundation.layout.statusBarsPadding
5+
import androidx.compose.ui.Modifier
46
import androidx.navigation.NavGraphBuilder
57
import androidx.navigation.NavType
68
import androidx.navigation.compose.composable
@@ -16,6 +18,7 @@ fun NavGraphBuilder.galleryPicker(
1618
) {
1719
composable(route = GALLERY_SCREEN) {
1820
GalleryPicker(
21+
modifier = Modifier.statusBarsPadding(),
1922
onImageSelected = onImageSelected
2023
)
2124
}

gallery-picker/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ publishing {
5050
register<MavenPublication>("release") {
5151
groupId = "run.nabla"
5252
artifactId = "gallery-picker"
53-
version = "1.4.4"
53+
version = "1.4.5"
5454
afterEvaluate {
5555
from(components["release"])
5656
}

gallery-picker/src/main/kotlin/run/nabla/gallerypicker/picker/GalleryPicker.kt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import androidx.compose.foundation.layout.aspectRatio
88
import androidx.compose.foundation.layout.fillMaxWidth
99
import androidx.compose.foundation.layout.heightIn
1010
import androidx.compose.foundation.layout.padding
11-
import androidx.compose.foundation.layout.statusBarsPadding
11+
import androidx.compose.foundation.lazy.staggeredgrid.LazyStaggeredGridState
1212
import androidx.compose.foundation.lazy.staggeredgrid.LazyVerticalStaggeredGrid
1313
import androidx.compose.foundation.lazy.staggeredgrid.StaggeredGridCells
1414
import androidx.compose.foundation.lazy.staggeredgrid.StaggeredGridItemSpan
@@ -32,12 +32,13 @@ import run.nabla.gallerypicker.permission.RequestPermissionScreen
3232
import run.nabla.gallerypicker.permission.RequestPermissionState
3333
import run.nabla.gallerypicker.permission.rememberRequestPermissionState
3434

35-
@OptIn(ExperimentalMaterialApi::class, ExperimentalPermissionsApi::class)
35+
@OptIn(ExperimentalPermissionsApi::class, ExperimentalMaterialApi::class)
3636
@Composable
3737
fun GalleryPicker(
3838
modifier: Modifier = Modifier,
3939
state: GalleryPickerState = rememberGalleryPickerState(),
4040
permissionState: RequestPermissionState = rememberRequestPermissionState(),
41+
lazyGridState: LazyStaggeredGridState = rememberLazyStaggeredGridState(),
4142
backgroundColor: Color = Color.Black,
4243
header: @Composable () -> Unit = {
4344
GalleryHeader(
@@ -47,7 +48,6 @@ fun GalleryPicker(
4748
onImageSelected: (Uri) -> Unit,
4849
) {
4950
val context = LocalContext.current
50-
val lazyGridState = rememberLazyStaggeredGridState()
5151
val storagePermissionState = rememberPermissionState(
5252
Manifest.permission.READ_EXTERNAL_STORAGE
5353
)
@@ -64,7 +64,6 @@ fun GalleryPicker(
6464
LazyVerticalStaggeredGrid(
6565
modifier = modifier
6666
.background(backgroundColor)
67-
.statusBarsPadding()
6867
.padding(horizontal = state.horizontalPadding.dp)
6968
.fillMaxWidth(),
7069
state = lazyGridState,

gallery-picker/src/main/kotlin/run/nabla/gallerypicker/picker/GalleryPickerActivity.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,10 @@ import android.os.Bundle
77
import androidx.activity.ComponentActivity
88
import androidx.activity.OnBackPressedCallback
99
import androidx.activity.compose.setContent
10+
import androidx.compose.foundation.layout.statusBarsPadding
1011
import androidx.compose.material.MaterialTheme
1112
import androidx.compose.material.Typography
13+
import androidx.compose.ui.Modifier
1214
import androidx.compose.ui.graphics.Color
1315
import androidx.compose.ui.text.font.Font
1416
import androidx.compose.ui.text.font.FontFamily
@@ -60,6 +62,7 @@ class GalleryPickerActivity : ComponentActivity() {
6062

6163
MaterialTheme(typography = typography) {
6264
GalleryPicker(
65+
modifier = Modifier.statusBarsPadding(),
6366
onImageSelected = onImageSelected,
6467
backgroundColor = Color(request.backgroundColor.toULong()),
6568
state = rememberGalleryPickerState(

0 commit comments

Comments
 (0)