Skip to content

Commit 7347d8d

Browse files
committed
reset branch error state (resolves #114)
1 parent 6a38db4 commit 7347d8d

File tree

4 files changed

+23
-7
lines changed

4 files changed

+23
-7
lines changed

ui/src/Components/DashBoard/Repository/GitComponents/GitTrackedComponent.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,11 @@ export default function GitTrackedComponent(props) {
255255
<div
256256
className={`git-tracked--menu-default ${styleSelector}`}
257257
key={item}
258-
onClick={(event) => {
258+
onClick={() => {
259259
setTopMenuItemState(item);
260+
// Resetting branch error in top bar component to prevent the error banner from getting displayed after \
261+
// switching the menu
262+
props.resetBranchError();
260263
}}
261264
>
262265
{item}

ui/src/Components/DashBoard/Repository/RepoComponents/RepositoryAction.js

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,12 @@ export default function RepositoryAction() {
3030
const memoizedGitTracker = useMemo(() => {
3131
if (defaultRepo && defaultRepo.id) {
3232
return (
33-
<GitTrackedComponent repoId={defaultRepo.id}></GitTrackedComponent>
33+
<GitTrackedComponent
34+
repoId={defaultRepo.id}
35+
resetBranchError={() => {
36+
setBranchError(false);
37+
}}
38+
></GitTrackedComponent>
3439
);
3540
}
3641
}, [defaultRepo]);
@@ -176,7 +181,11 @@ export default function RepositoryAction() {
176181
<select
177182
className="top-pane--select bg-green-100 text-green-700 border-green-400"
178183
defaultValue={"checked"}
184+
onClick={() => {
185+
setBranchError(false);
186+
}}
179187
onChange={(event) => {
188+
setActiveBranch("...");
180189
if (event.currentTarget.value !== defaultRepo.repoName) {
181190
setSelectedRepoDetails({
182191
...selectedRepoDetails,
@@ -211,18 +220,22 @@ export default function RepositoryAction() {
211220
<div className="flex items-center">
212221
<div className="select--label">Branch</div>
213222
<select
214-
className="top-pane--select bg-indigo-100 border-indigo-400 text-indigo-700 "
215223
value={activeBranch}
224+
defaultChecked={activeBranch}
225+
className="top-pane--select bg-indigo-100 border-indigo-400 text-indigo-700"
216226
disabled={activeBranch ? false : true}
217227
onChange={(event) => {
218228
event.persist();
219-
setActiveBranch("");
229+
setActiveBranch("...");
220230
setTrackingBranch(event.target.value, event);
221231
}}
222232
onClick={() => {
223233
setBranchError(false);
224234
}}
225235
>
236+
<option key={activeBranch} value={activeBranch}>
237+
{activeBranch}
238+
</option>
226239
{availableBranch()}
227240
</select>
228241
</div>
@@ -249,7 +262,7 @@ export default function RepositoryAction() {
249262
const { gitBranchList } = selectedRepoDetails;
250263

251264
return gitBranchList.map((branch, index) => {
252-
if (branch !== "NO_BRANCH") {
265+
if (branch !== "NO_BRANCH" && branch !== activeBranch) {
253266
return (
254267
<option key={branch} value={branch}>
255268
{branch}

ui/src/Components/DashBoard/Settings/Settings.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ export default function Settings(props) {
212212
) : null}
213213

214214
{deleteRepoStatus === "loading" ? (
215-
<div className="cursor-pointer mx-auto my-4 text-center p-3 text-white rounded shadow bg-gray-400 hover:bg-gray-500 text-white text-xl">
215+
<div className="cursor-pointer mx-auto my-4 text-center p-3 rounded shadow bg-gray-400 hover:bg-gray-500 text-white text-xl">
216216
Deletion in progress
217217
</div>
218218
) : null}

ui/src/Components/styles/GitDiffView.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
}
7878

7979
.git-diff--files--filename_lg {
80-
font-size: 1.25rem;
80+
font-size: 1rem;
8181
margin-left: 0.5rem;
8282
margin-right: 0.5rem;
8383
border-bottom-width: 1px;

0 commit comments

Comments
 (0)