-
Notifications
You must be signed in to change notification settings - Fork 712
Upgrade to AWS Java SDK v2 #6165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
b239ab9
first modifications
jorgee ce52d31
first nio changes
jorgee 946abe0
convert nio package to sdk v2
jorgee eabc184
fix for test in V2
jorgee 7349661
fix tests
jorgee 623ae2b
fix rebase error
jorgee b06ec93
fix some tests
jorgee 68f76cd
fix upload dir and tagging overwrite in copy
jorgee f88bafe
fix get caller account when acl call fails
jorgee 8b2f30b
fix get caller account when acl call fails
jorgee a1d6cc0
fix tagging test
jorgee 9612146
some clean up
jorgee 6a9375a
Merge branch 'master' into aws-sdk-v2-fs-impl
jorgee 5a2105c
Return http client builder in S3ClientConfiguration and new tests
jorgee 1bcddbe
fix test and update sdk version
jorgee 7328873
Update docs [ci fast]
bentsherman 951f23e
cleanup
bentsherman 2829e7e
add crt client
jorgee ac83841
fix issues with ClientOverrideOptions, netty S3 Async client and S3 c…
jorgee c1f3151
add new crt options
jorgee dfffad5
Add lang config options and fix s3 tranfer manager actions error logs
jorgee 6dd2761
Apply suggestions from code review [ci skip]
jorgee 2095cdd
remove S3 netty client option
jorgee f09b08e
remove netty test
jorgee b00f7a2
cleanup docs
bentsherman 26da281
fix infinite loop in S3iterator and remove unused import in test
jorgee d491d3c
adding v1 to v2 migration text
jorgee a2554a0
changing deprecated comment in uploads options
jorgee 90a1457
Merge branch 'master' into aws-sdk-v2-fs-impl
jorgee b456c2f
Update docs
bentsherman 94bc3af
test [e2e prod]
pditommaso 9b04ec4
update loggers with sdk v2 package prefix
jorgee fd86ab4
Use aws batch request model adapter
pditommaso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
(aws-java-sdk-v2-page)= | ||
|
||
# AWS Java SDK v2 | ||
|
||
AWS Java SDK v1 is reaching end of life at the end of 2025. Starting in version `25.06.0-edge`, Nextflow uses AWS Java SDK v2 in the `nf-amazon` plugin. | ||
|
||
This migration introduced several breaking changes to the `aws.client` config scope, including new options and removed options. This page describes these changes and how they affect your Nextflow configuraiton. | ||
|
||
## New HTTP client | ||
|
||
The HTTP client used by SDK v2 does not support overriding certain advanced HTTP options. As a result, the following config options are no longer supported: | ||
|
||
- `aws.client.protocol` | ||
- `aws.client.signerOverride` | ||
- `aws.client.socketRecvBufferSizeHint` | ||
- `aws.client.socketSendBufferSizeHint` | ||
- `aws.client.userAgent` | ||
|
||
## S3 transfer manager | ||
|
||
The *S3 transfer manager* is a subsystem of SDK v2 which handles S3 transfers, including S3 uploads and downloads. | ||
|
||
The concurrency and throughput of the S3 transfer manager can be configured manually using the `aws.client.maxConcurrency` and `aws.client.maxNativeMemory` config options. Alternatively, the `aws.client.targetThroughputInGbps` config option can be used to set the previous two options automatically based on a target throughput. | ||
|
||
## Multi-part uplaods | ||
|
||
Multi-part uploads are handled by the S3 transfer manager. The `aws.client.minimumPartSize` and `aws.client.multipartThreshold` config options can be used to control when and how multi-part uploads are performed. | ||
|
||
The following multi-part upload options are no longer supported: | ||
|
||
- `aws.client.uploadChunkSize` | ||
- `aws.client.uploadMaxAttempts` | ||
- `aws.client.uploadMaxThreads` | ||
- `aws.client.uploadRetrySleep` |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
(migrating-25-10-page)= | ||
|
||
# Migrating to 25.10 (preview) | ||
|
||
This page summarizes the upcoming changes in Nextflow 25.10, which will be released in October 2025. | ||
|
||
:::{note} | ||
This page is a work in progress and will be updated as features are finalized. It should not be considered complete until the 25.10 release. | ||
::: | ||
|
||
## Breaking changes | ||
|
||
- The AWS Java SDK used by Nextflow was upgraded from v1 to v2, which introduced some breaking changes to the `aws.client` config options. See {ref}`the guide <aws-java-sdk-v2-page>` for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.