Skip to content

Commit 4df3aeb

Browse files
committed
fix(native deps): not marked as externals if they have index.js
1 parent a99db83 commit 4df3aeb

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

__tests__/webpackConfig.spec.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -168,15 +168,6 @@ describe.each(['production', 'development'])('getExternals in %s', env => {
168168
}
169169
)
170170

171-
test('If dep has index.js it should not be external', async () => {
172-
// Mock existence of index.js
173-
fs.existsSync = jest.fn(file => file === 'mockExternalIndex')
174-
const { externals } = await mockGetExternals()
175-
expect(externals).toBeUndefined()
176-
// Remove mock
177-
fs.existsSync.mockReset()
178-
})
179-
180171
test('If dep is listed in user list it should be an external', async () => {
181172
const { externals } = await mockGetExternals(
182173
// Prevent it from getting marked as an external by default

lib/webpackConfig.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,6 @@ function getExternals (api, pluginOptions) {
5252
const externalsList = Object.keys(dependencies || {}).filter(dep => {
5353
// Return true if we want to add a dependency to externals
5454
try {
55-
if (fs.existsSync(api.resolve(`./node_modules/${dep}/index.js`))) {
56-
return false
57-
}
5855
const pgkString = fs
5956
.readFileSync(api.resolve(`./node_modules/${dep}/package.json`))
6057
.toString()

0 commit comments

Comments
 (0)