Skip to content

Commit 6a950a4

Browse files
authored
Merge pull request #27 from nobrainr/Fix/remove-lodash-dep
Fix/remove lodash dep
2 parents fb73437 + 4582cfc commit 6a950a4

File tree

8 files changed

+14
-36
lines changed

8 files changed

+14
-36
lines changed

.circleci/config.yml

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -10,52 +10,26 @@ jobs:
1010
working_directory: ~/repo
1111
steps:
1212
- checkout
13-
# Download and cache dependencies
14-
- restore_cache:
15-
keys:
16-
- v1-dependencies-{{ checksum "package-lock.json" }}
17-
# fallback to using the latest cache if no exact match is found
18-
- v1-dependencies-
1913
- run: npm install
2014
- run: npm run build
2115
- run: npm test
22-
- save_cache:
23-
paths:
24-
- node_modules
25-
- packages/cli
26-
key: v1-dependencies-{{ checksum "package-lock.json" }}
2716
test-job-10:
2817
docker:
2918
- image: circleci/node:10-browsers
3019
working_directory: ~/repo
3120
steps:
3221
- checkout
33-
# Download and cache dependencies
34-
- restore_cache:
35-
keys:
36-
- v1-dependencies-{{ checksum "package-lock.json" }}
37-
# fallback to using the latest cache if no exact match is found
38-
- v1-dependencies-
3922
- run: npm install
4023
- run: npm run build
4124
- run: npm test
42-
- save_cache:
43-
paths:
44-
- node_modules
45-
- packages/cli
46-
key: v1-dependencies-{{ checksum "package-lock.json" }}
4725

4826
publish-job:
4927
docker:
5028
- image: circleci/node:10
5129
working_directory: ~/repo
5230
steps:
5331
- checkout
54-
- restore_cache:
55-
keys:
56-
- v1-dependencies-{{ checksum "package-lock.json" }}
57-
# fallback to using the latest cache if no exact match is found
58-
- v1-dependencies-
32+
- run: npm install
5933
- run:
6034
name: Pre-Publish Script
6135
command: ./tools/publish.sh

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,5 @@ app/
99
node_modules/
1010
src/build/
1111
coverage/
12+
*-debug.log
13+

lerna.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55
}
66
},
77
"packages": ["packages/*"],
8-
"version": "0.2.6"
8+
"version": "0.3.1"
99
}

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"main": "src/index.ts",
66
"scripts": {
77
"build": "lerna bootstrap",
8+
"update-cli-in-e2e": "lerna add create-ts-lib packages/e2e",
89
"test": "cd packages/e2e && npm test",
910
"publish": "lerna run publish-cli"
1011
},

packages/cli/package-lock.json

Lines changed: 6 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/cli/template/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,5 @@
4444
"webpack-cli": "^3.1.0",
4545
"webpack-dev-server": "^3.1.5"
4646
},
47-
"dependencies": {
48-
"lodash": "^4.17.4"
49-
}
47+
"dependencies": {}
5048
}

packages/cli/template/src/MyLibrary.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
1-
import { random } from 'lodash';
2-
31
export interface Foo {
42
executeDependency: Function;
53
}
64

75
export class MyLibrary implements Foo {
86
executeDependency() {
9-
return random(0, 10);
7+
return Math.floor(Math.random() * 10 + 1);
108
}
119
}
1210

packages/e2e/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"test": "create-ts-lib app && cd app && npm run build && npm run test"
1010
},
1111
"dependencies": {
12-
"create-ts-lib": "^0.2.6",
12+
"create-ts-lib": "^0.3.1",
1313
"rimraf": "^2.6.2"
1414
},
1515
"keywords": [],

0 commit comments

Comments
 (0)